2018-01-20 21:00:38

by SF Markus Elfring

Subject: [PATCH 0/2] Input: tps6507x-ts: Adjustments for tps6507x_ts_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 20 Jan 2018 21:53:21 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/input/touchscreen/tps6507x-ts.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--
2.15.1

2018-01-20 21:02:55

by SF Markus Elfring

Subject: [PATCH 2/2] Input: tps6507x-ts: Improve a size determination in tps6507x_ts_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 20 Jan 2018 21:47:16 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/touchscreen/tps6507x-ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
index 5b2756ec1766..83b24e202d8e 100644
--- a/drivers/input/touchscreen/tps6507x-ts.c
+++ b/drivers/input/touchscreen/tps6507x-ts.c
@@ -226,7 +226,7 @@ static int tps6507x_ts_probe(struct platform_device *pdev)
*/
init_data = tps_board->tps6507x_ts_init_data;

- tsc = devm_kzalloc(&pdev->dev, sizeof(struct tps6507x_ts), GFP_KERNEL);
+ tsc = devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL);
if (!tsc)
return -ENOMEM;

--
2.15.1

2018-01-20 21:03:31

by SF Markus Elfring

Subject: [PATCH 1/2] Input: tps6507x-ts: Delete an error message for a failed memory allocation in tps6507x_ts_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 20 Jan 2018 21:43:54 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/touchscreen/tps6507x-ts.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
index 75170a7439b1..5b2756ec1766 100644
--- a/drivers/input/touchscreen/tps6507x-ts.c
+++ b/drivers/input/touchscreen/tps6507x-ts.c
@@ -227,10 +227,8 @@ static int tps6507x_ts_probe(struct platform_device *pdev)
init_data = tps_board->tps6507x_ts_init_data;

tsc = devm_kzalloc(&pdev->dev, sizeof(struct tps6507x_ts), GFP_KERNEL);
- if (!tsc) {
- dev_err(tps6507x_dev->dev, "failed to allocate driver data\n");
+ if (!tsc)
return -ENOMEM;
- }

tsc->mfd = tps6507x_dev;
tsc->dev = tps6507x_dev->dev;
--
2.15.1