2022-01-24 19:26:49

by Carsten Haitzler

Subject: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER

From: Carsten Haitzler <[email protected]>

Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.

Signed-off-by: Carsten Haitzler <[email protected]>
---
drivers/gpu/drm/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 58a242871b28..6e3f1d600541 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -6,6 +6,7 @@ config DRM_HDLCD
depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
depends on COMMON_CLK
select DRM_KMS_HELPER
+ select DRM_GEM_CMA_HELPER
help
Choose this option if you have an ARM High Definition Colour LCD
controller.
--
2.30.1

2022-01-24 19:32:54

by Steven Price

Subject: Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER

On 24/01/2022 15:13, [email protected] wrote:
> From: Carsten Haitzler <[email protected]>
>
> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
>
> Signed-off-by: Carsten Haitzler <[email protected]>

To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that
was removed in commit 09717af7d13d ("drm: Remove
CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select
DRM_GEM_CMA_HELPER but that transitive dependency was lost and
apparently the fixup was missed in that commit.

So we need a:

Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")

and with that...

Reviewed-by: Steven Price <[email protected]>

Steve

> ---
> drivers/gpu/drm/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> index 58a242871b28..6e3f1d600541 100644
> --- a/drivers/gpu/drm/arm/Kconfig
> +++ b/drivers/gpu/drm/arm/Kconfig
> @@ -6,6 +6,7 @@ config DRM_HDLCD
> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> depends on COMMON_CLK
> select DRM_KMS_HELPER
> + select DRM_GEM_CMA_HELPER
> help
> Choose this option if you have an ARM High Definition Colour LCD
> controller.
>

2022-01-24 19:33:46

by Carsten Haitzler

Subject: Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER

I sent an updated patch with the Fixes:

On 1/24/22 16:13, Steven Price wrote:
> On 24/01/2022 15:13, [email protected] wrote:
>> From: Carsten Haitzler <[email protected]>
>>
>> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
>>
>> Signed-off-by: Carsten Haitzler <[email protected]>
>
> To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that
> was removed in commit 09717af7d13d ("drm: Remove
> CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select
> DRM_GEM_CMA_HELPER but that transitive dependency was lost and
> apparently the fixup was missed in that commit.
>
> So we need a:
>
> Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
>
> and with that...
>
> Reviewed-by: Steven Price <[email protected]>
>
> Steve
>
>> ---
>> drivers/gpu/drm/arm/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
>> index 58a242871b28..6e3f1d600541 100644
>> --- a/drivers/gpu/drm/arm/Kconfig
>> +++ b/drivers/gpu/drm/arm/Kconfig
>> @@ -6,6 +6,7 @@ config DRM_HDLCD
>> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
>> depends on COMMON_CLK
>> select DRM_KMS_HELPER
>> + select DRM_GEM_CMA_HELPER
>> help
>> Choose this option if you have an ARM High Definition Colour LCD
>> controller.
>>
>