2022-10-31 15:33:37

by Matthew Wilcox

Subject: Re: [RFC PATCH 0/2] iov_iter: Provide a function to extract/pin/get pages from an iteraor

On Mon, Oct 31, 2022 at 02:49:32PM +0000, David Howells wrote:
> I added a macro by which you can query an iterator to find out how the
> extraction function will treat the pages (it returns 0, FOLL_GET or FOLL_PIN
> as appropriate). Note that it's a macro to avoid #inclusion of linux/mm.h in
> linux/uio.h.

I'd support moving FOLL_* definitions to mm_types.h along with
FAULT_FLAG_* and VM_FAULT_*.

2022-10-31 21:39:05

by John Hubbard

Subject: Re: [RFC PATCH 0/2] iov_iter: Provide a function to extract/pin/get pages from an iteraor

On 10/31/22 07:52, Matthew Wilcox wrote:
> On Mon, Oct 31, 2022 at 02:49:32PM +0000, David Howells wrote:
>> I added a macro by which you can query an iterator to find out how the
>> extraction function will treat the pages (it returns 0, FOLL_GET or FOLL_PIN
>> as appropriate). Note that it's a macro to avoid #inclusion of linux/mm.h in
>> linux/uio.h.
>
> I'd support moving FOLL_* definitions to mm_types.h along with
> FAULT_FLAG_* and VM_FAULT_*.

+1, great idea. The use of FOLL_* without including it's .h directly was
the first thing that jumped out at me when I just started looking at
this. And these really are mm types, so yes.

thanks,
--
John Hubbard
NVIDIA