2023-03-19 15:29:30

by Menna Mahmoud

Subject: [PATCH] staging: greybus: remove unnecessary blank line

Remove unnecessary blank line before struct as reported
by checkpatch:

" CHECK: Please don't use multiple blank lines "

Signed-off-by: Menna Mahmoud <[email protected]>
---
drivers/staging/greybus/pwm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
index 3fda172239d2..26d39e08c3b6 100644
--- a/drivers/staging/greybus/pwm.c
+++ b/drivers/staging/greybus/pwm.c
@@ -24,7 +24,6 @@ struct gb_pwm_chip {
#define pwm_chip_to_gb_pwm_chip(chip) \
container_of(chip, struct gb_pwm_chip, chip)

-
static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
{
struct gb_pwm_count_response response;
--
2.34.1

2023-03-19 16:16:05

by Menna Mahmoud

Subject: Re: [PATCH] staging: greybus: remove unnecessary blank line

On ١٩‏/٣‏/٢٠٢٣ ١٨:٠٩, Fabio M. De Francesco wrote:
>
> On domenica 19 marzo 2023 16:29:09 CET Menna Mahmoud wrote:
>
> > Remove unnecessary blank line before struct as reported
>
> > by checkpatch:
>
> >
>
> > " CHECK: Please don't use multiple blank lines "
>
> >
>
> > Signed-off-by: Menna Mahmoud <[email protected]>
>
> > ---
>
> > drivers/staging/greybus/pwm.c | 1 -
>
> > 1 file changed, 1 deletion(-)
>
> >
>
> > diff --git a/drivers/staging/greybus/pwm.c
> b/drivers/staging/greybus/pwm.c
>
> > index 3fda172239d2..26d39e08c3b6 100644
>
> > --- a/drivers/staging/greybus/pwm.c
>
> > +++ b/drivers/staging/greybus/pwm.c
>
> > @@ -24,7 +24,6 @@ struct gb_pwm_chip {
>
> > #define pwm_chip_to_gb_pwm_chip(chip) \
>
> >     container_of(chip, struct gb_pwm_chip, chip)
>
> >
>
> > -
>
> > static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
>
> > {
>
> >     struct gb_pwm_count_response response;
>
> > --
>
> > 2.34.1
>
>
> Hi Menna,
>
>
Hi Fabio,


> I just saw that today you sent this patch at least three times:
>
>
> https://lore.kernel.org/linux-staging/[email protected]/
>

This for different file, and the below I sent it with other patch so I
resend it again.

>
> https://lore.kernel.org/linux-staging/[email protected]/
>
>
> https://lore.kernel.org/linux-staging/[email protected]/
>
>
> Why are you doing so?
>

sorry for this.

>
> Please send your patches only once and wait at least a week without
> any replies before resending. Furthermore, when resending, please
> explain under the three dashes ("---") why you are doing so. Patches
> may get lost, but this is not your case for sending them again and
> again in a single day.
>
got your point.

>
> Is there anything I'm missing?
>
>
> Thanks,
>
>
> Fabio
>
>
>

Thanks,

Menna