2024-04-05 15:02:38

by Théo Lebrun

[permalink] [raw]
Subject: [PATCH v2 01/11] spi: dt-bindings: cdns,qspi-nor: add mobileye,eyeq5-ospi compatible

Add Mobileye EyeQ5 compatible.
FIFO depth shall not be passed; hardware can detect it.

Reviewed-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Théo Lebrun <[email protected]>
---
Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
index cca81f89e252..5509c126b1cf 100644
--- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
+++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
@@ -61,6 +61,17 @@ allOf:
cdns,fifo-depth:
enum: [ 128, 256 ]
default: 128
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: mobileye,eyeq5-ospi
+ then:
+ properties:
+ cdns,fifo-depth: false
+ else:
+ required:
+ - cdns,fifo-depth

properties:
compatible:
@@ -68,6 +79,7 @@ properties:
- items:
- enum:
- amd,pensando-elba-qspi
+ - mobileye,eyeq5-ospi
- ti,k2g-qspi
- ti,am654-ospi
- intel,lgm-qspi
@@ -145,7 +157,6 @@ required:
- reg
- interrupts
- clocks
- - cdns,fifo-depth
- cdns,fifo-width
- cdns,trigger-address
- '#address-cells'

--
2.44.0



2024-04-08 14:14:19

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2 01/11] spi: dt-bindings: cdns,qspi-nor: add mobileye,eyeq5-ospi compatible

On Fri, Apr 05, 2024 at 05:02:11PM +0200, Th?o Lebrun wrote:

> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mobileye,eyeq5-ospi
> + then:
> + properties:
> + cdns,fifo-depth: false
> + else:
> + required:
> + - cdns,fifo-depth

My suggestions on the FIFO depth probe patch would mean this would turn
into making cdns,fifo-depth optional for everything. It certainly seems
like many instances of the hardware should support that anyway.


Attachments:
(No filename) (538.00 B)
signature.asc (499.00 B)
Download all attachments