2021-05-07 15:07:02

by Seung-Woo Kim

Subject: [RESEND][PATCH 1/2] resize.f2fs: fix memory leak caused by migrate_nat()

Alloced nat_block doesn't freed from migrate_nat(). Fix to free
nat_block.

Signed-off-by: Seung-Woo Kim <[email protected]>
---
fsck/resize.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fsck/resize.c b/fsck/resize.c
index b043cd984dc6..78d578ec2cc1 100644
--- a/fsck/resize.c
+++ b/fsck/resize.c
@@ -383,6 +383,7 @@ static void migrate_nat(struct f2fs_sb_info *sbi,
ASSERT(ret >= 0);
DBG(3, "Write NAT: %lx\n", block_addr);
}
+ free(nat_block);
DBG(0, "Info: Done to migrate NAT blocks: nat_blkaddr = 0x%x -> 0x%x\n",
old_nat_blkaddr, new_nat_blkaddr);
}
--
2.19.2

2021-05-07 15:28:05

by Seung-Woo Kim

Subject: [RESEND][PATCH 2/2] mkfs.f2fs: fix memory leak in not enough segments error path

In not enough segements error path of f2fs_write_check_point_pack(),
cp_payload is not freed. Fix the error path.

Signed-off-by: Seung-Woo Kim <[email protected]>
---
mkfs/f2fs_format.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
index 3f1fa32a407a..fbecb05b3302 100644
--- a/mkfs/f2fs_format.c
+++ b/mkfs/f2fs_format.c
@@ -723,7 +723,7 @@ static int f2fs_write_check_point_pack(void)

if (f2fs_get_usable_segments(sb) <= get_cp(overprov_segment_count)) {
MSG(0, "\tError: Not enough segments to create F2FS Volume\n");
- goto free_nat_bits;
+ goto free_cp_payload;
}
MSG(0, "Info: Overprovision ratio = %.3lf%%\n", c.overprovision);
MSG(0, "Info: Overprovision segments = %u (GC reserved = %u)\n",
--
2.19.2

2021-05-08 06:30:59

by Chao Yu

Subject: Re: [f2fs-dev] [RESEND][PATCH 1/2] resize.f2fs: fix memory leak caused by migrate_nat()

On 2021/5/7 19:12, Seung-Woo Kim wrote:
> Alloced nat_block doesn't freed from migrate_nat(). Fix to free
> nat_block.
>
> Signed-off-by: Seung-Woo Kim <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2021-05-08 06:32:21

by Chao Yu

Subject: Re: [f2fs-dev] [RESEND][PATCH 2/2] mkfs.f2fs: fix memory leak in not enough segments error path

On 2021/5/7 19:12, Seung-Woo Kim wrote:
> In not enough segements error path of f2fs_write_check_point_pack(),
> cp_payload is not freed. Fix the error path.
>
> Signed-off-by: Seung-Woo Kim <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,