2017-11-13 13:57:31

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 0/3] irqchip: pr_err() strings should end with newlines

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Arvind Yadav (3):
[PATCH 1/3] irqchip/mips-gic: pr_err() strings should end with newlines
[PATCH 2/3] irqchip/s3c24xx: pr_err() strings should end with newlines
[PATCH 3/3] irqchip/gic-v3: pr_err() strings should end with newlines

drivers/irqchip/irq-gic-v3.c | 2 +-
drivers/irqchip/irq-mips-gic.c | 4 ++--
drivers/irqchip/irq-s3c24xx.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)

--
1.9.1


From 1584078757656233609@xxx Tue Nov 14 21:33:46 +0000 2017
X-GM-THRID: 1584078757656233609
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread


2017-11-13 13:56:04

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 2/3] irqchip/s3c24xx: pr_err() strings should end with newlines

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/irqchip/irq-s3c24xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
index c25ce5a..ec0e6a8 100644
--- a/drivers/irqchip/irq-s3c24xx.c
+++ b/drivers/irqchip/irq-s3c24xx.c
@@ -156,7 +156,7 @@ static int s3c_irq_type(struct irq_data *data, unsigned int type)
irq_set_handler(data->irq, handle_level_irq);
break;
default:
- pr_err("No such irq type %d", type);
+ pr_err("No such irq type %d\n", type);
return -EINVAL;
}

@@ -204,7 +204,7 @@ static int s3c_irqext_type_set(void __iomem *gpcon_reg,
break;

default:
- pr_err("No such irq type %d", type);
+ pr_err("No such irq type %d\n", type);
return -EINVAL;
}

--
1.9.1


From 1583946574833274204@xxx Mon Nov 13 10:32:46 +0000 2017
X-GM-THRID: 1583946574833274204
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread

2017-11-13 13:57:13

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 3/3] irqchip/gic-v3: pr_err() strings should end with newlines

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/irqchip/irq-gic-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index b5df99c..252fb0c 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -1489,7 +1489,7 @@ static void __init gic_acpi_setup_kvm_info(void)

err = gic_validate_dist_version(acpi_data.dist_base);
if (err) {
- pr_err("No distributor detected at @%p, giving up",
+ pr_err("No distributor detected at @%p, giving up\n",
acpi_data.dist_base);
goto out_dist_unmap;
}
--
1.9.1


From 1583764333924290591@xxx Sat Nov 11 10:16:08 +0000 2017
X-GM-THRID: 1583574741369515099
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread