2002-01-02 12:46:32

by Albert Cranford

Subject: [PATCH] 2.4.18-pre1 sound/trident fix with newer binutils

Hello Ollie,
Small problem.
I cannot build kernel with binutils-2.11.92.0.12.3

Using ARCH='i386' AS='as' LD='ld' CC='/usr/bin/gcc' CPP='/usr/bin/gcc -E' AR='ar' HOSTAS='as' HOSTLD='gcc' HOSTCC='gcc' HOSTAR='ar'
drivers/sound/trident.o(.data+0x154): undefined reference to `local symbols in discarded section .text.exit'

Please submit the attached patch to Marcelo and Linus
for 2.4 and 2.5 respectfully. This patch also works
with older binutils-2.11.2
Thanks,
Albert
--- linux-2.4.18-pre1/drivers/sound/trident.c.orig Mon Dec 31 16:32:25 2001
+++ linux/drivers/sound/trident.c Mon Dec 31 16:32:44 2001
@@ -4141,7 +4141,7 @@
goto out;
}

-static void __exit trident_remove(struct pci_dev *pci_dev)
+static void __devexit trident_remove(struct pci_dev *pci_dev)
{
int i;
struct trident_card *card = pci_get_drvdata(pci_dev);
@@ -4194,7 +4194,9 @@
name: TRIDENT_MODULE_NAME,
id_table: trident_pci_tbl,
probe: trident_probe,
+#ifdef DEVEXIT_LINKED
remove: trident_remove,
+#endif
suspend: trident_suspend,
resume: trident_resume
};
@@ -4214,7 +4216,7 @@
return 0;
}

-static void __exit trident_cleanup_module (void)
+static void __devexit trident_cleanup_module (void)
{
pci_unregister_driver(&trident_pci_driver);
}


--
Albert Cranford Deerfield Beach FL USA
[email protected]

2002-01-02 13:09:04

by Keith Owens

Subject: Re: [PATCH] 2.4.18-pre1 sound/trident fix with newer binutils

On Wed, 02 Jan 2002 07:46:12 -0500,
Albert Cranford <[email protected]> wrote:
>Hello Ollie,
>Small problem.
>I cannot build kernel with binutils-2.11.92.0.12.3
>
>drivers/sound/trident.o(.data+0x154): undefined reference to `local symbols in discarded section .text.exit'
>+#ifdef DEVEXIT_LINKED
> remove: trident_remove,
>+#endif

What is DEVEXIT_LINKED? The correct form is
remove: __devexit_p(trident_remove),