2022-05-09 06:00:19

by John Fastabend

[permalink] [raw]
Subject: RE: [PATCH bpf-next v2 2/2] riscv, bpf: Support riscv jit to provide bpf_line_info

Pu Lehui wrote:
> Add support for riscv jit to provide bpf_line_info.
> We need to consider the prologue offset in ctx->offset,
> but unlike x86 and arm64, ctx->offset of riscv does not
> provide an extra slot for the prologue, so here we just
> calculate the len of prologue and add it to ctx->offset
> at the end. Both RV64 and RV32 have been tested.
>
> Signed-off-by: Pu Lehui <[email protected]>
> ---

Looks reasonable to me, but would be good if someone with RISC
knowledge takes a lookt hough.