2022-06-21 23:31:16

by John Fastabend

[permalink] [raw]
Subject: RE: [PATCH v5 4/5] selftests/bpf: Add test for unreleased key references

Roberto Sassu wrote:
> Ensure that the verifier detects the attempt of acquiring a reference of a
> key through the helper bpf_lookup_user_key(), without releasing that
> reference with bpf_key_put(), and refuses to load the program.
>
> Signed-off-by: Roberto Sassu <[email protected]>
> ---

Any reason not to add these to ./verifier/ref_tracking.c tests? Seems it
might be easier to follow there and test both good/bad cases.