2024-03-26 17:31:36

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] drm: DRM_WERROR should depend on DRM

There is no point in asking the user about enforcing the DRM compiler
warning policy when configuring a kernel without DRM support.

Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/gpu/drm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index f2bcf5504aa77679..2e1b23ccf30423a9 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -423,7 +423,7 @@ config DRM_PRIVACY_SCREEN

config DRM_WERROR
bool "Compile the drm subsystem with warnings as errors"
- depends on EXPERT
+ depends on DRM && EXPERT
default n
help
A kernel build should not cause any compiler warnings, and this
--
2.34.1



2024-03-26 17:34:31

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] drm: DRM_WERROR should depend on DRM

On Tue, Mar 26, 2024 at 6:31 PM Geert Uytterhoeven
<[email protected]> wrote:
> There is no point in asking the user about enforcing the DRM compiler
> warning policy when configuring a kernel without DRM support.
>
> Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

My apologies, something went wrong with the list of recipients.
Please ignore.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2024-03-26 20:14:08

by Jani Nikula

[permalink] [raw]
Subject: Re: [PATCH] drm: DRM_WERROR should depend on DRM

On Tue, 26 Mar 2024, Geert Uytterhoeven <[email protected]> wrote:
> There is no point in asking the user about enforcing the DRM compiler
> warning policy when configuring a kernel without DRM support.
>
> Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

D'oh! My bad.

Reviewed-by: Jani Nikula <[email protected]>

> ---
> drivers/gpu/drm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index f2bcf5504aa77679..2e1b23ccf30423a9 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -423,7 +423,7 @@ config DRM_PRIVACY_SCREEN
>
> config DRM_WERROR
> bool "Compile the drm subsystem with warnings as errors"
> - depends on EXPERT
> + depends on DRM && EXPERT
> default n
> help
> A kernel build should not cause any compiler warnings, and this

--
Jani Nikula, Intel

2024-03-28 11:11:20

by Jani Nikula

[permalink] [raw]
Subject: Re: [PATCH] drm: DRM_WERROR should depend on DRM

On Tue, 26 Mar 2024, Jani Nikula <[email protected]> wrote:
> On Tue, 26 Mar 2024, Geert Uytterhoeven <[email protected]> wrote:
>> There is no point in asking the user about enforcing the DRM compiler
>> warning policy when configuring a kernel without DRM support.
>>
>> Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR")
>> Signed-off-by: Geert Uytterhoeven <[email protected]>
>
> D'oh! My bad.
>
> Reviewed-by: Jani Nikula <[email protected]>

And pushed to drm-misc-next. Thanks for the patch!

BR,
Jani.

>
>> ---
>> drivers/gpu/drm/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
>> index f2bcf5504aa77679..2e1b23ccf30423a9 100644
>> --- a/drivers/gpu/drm/Kconfig
>> +++ b/drivers/gpu/drm/Kconfig
>> @@ -423,7 +423,7 @@ config DRM_PRIVACY_SCREEN
>>
>> config DRM_WERROR
>> bool "Compile the drm subsystem with warnings as errors"
>> - depends on EXPERT
>> + depends on DRM && EXPERT
>> default n
>> help
>> A kernel build should not cause any compiler warnings, and this

--
Jani Nikula, Intel