2018-12-03 18:43:54

by Dan Williams

Subject: [PATCH] acpi/nfit: Fix user-initiated ARS to be "ARS-long" rather than "ARS-short"

A "short" ARS (address range scrub) instructs the platform firmware to
return known errors. In contrast, a "long" ARS instructs platform
firmware to arrange every data address on the DIMM to be read / checked
for poisoned data.

The conversion of the flags in commit d3abaf43bab8 "acpi, nfit: Fix
Address Range Scrub completion tracking", changed the meaning of passing
'0' to acpi_nfit_ars_rescan(). Previously '0' meant "not short", now '0'
is ARS_REQ_SHORT. Pass ARS_REQ_LONG to restore the expected scrub-type
behavior of user-initiated ARS sessions.

Fixes: d3abaf43bab8 ("acpi, nfit: Fix Address Range Scrub completion tracking")
Reported-by: Jacek Zloch <[email protected]>
Cc: Vishal Verma <[email protected]>
Signed-off-by: Dan Williams <[email protected]>
---
drivers/acpi/nfit/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index 14d9f5bea015..5912d30020c7 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -1308,7 +1308,7 @@ static ssize_t scrub_store(struct device *dev,
if (nd_desc) {
struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc);

- rc = acpi_nfit_ars_rescan(acpi_desc, 0);
+ rc = acpi_nfit_ars_rescan(acpi_desc, ARS_REQ_LONG);
}
device_unlock(dev);
if (rc)

2018-12-03 20:14:43

by Dave Jiang

Subject: Re: [PATCH] acpi/nfit: Fix user-initiated ARS to be "ARS-long" rather than "ARS-short"

On 12/3/2018 11:30 AM, Dan Williams wrote:
> A "short" ARS (address range scrub) instructs the platform firmware to
> return known errors. In contrast, a "long" ARS instructs platform
> firmware to arrange every data address on the DIMM to be read / checked
> for poisoned data.
>
> The conversion of the flags in commit d3abaf43bab8 "acpi, nfit: Fix
> Address Range Scrub completion tracking", changed the meaning of passing
> '0' to acpi_nfit_ars_rescan(). Previously '0' meant "not short", now '0'
> is ARS_REQ_SHORT. Pass ARS_REQ_LONG to restore the expected scrub-type
> behavior of user-initiated ARS sessions.
>
> Fixes: d3abaf43bab8 ("acpi, nfit: Fix Address Range Scrub completion tracking")
> Reported-by: Jacek Zloch <[email protected]>
> Cc: Vishal Verma <[email protected]>
> Signed-off-by: Dan Williams <[email protected]>
Reviewed-by: Dave Jiang <[email protected]>
> ---
> drivers/acpi/nfit/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 14d9f5bea015..5912d30020c7 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1308,7 +1308,7 @@ static ssize_t scrub_store(struct device *dev,
> if (nd_desc) {
> struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc);
>
> - rc = acpi_nfit_ars_rescan(acpi_desc, 0);
> + rc = acpi_nfit_ars_rescan(acpi_desc, ARS_REQ_LONG);
> }
> device_unlock(dev);
> if (rc)
>
> _______________________________________________
> Linux-nvdimm mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/linux-nvdimm

2018-12-03 21:20:25

by Verma, Vishal L

Subject: Re: [PATCH] acpi/nfit: Fix user-initiated ARS to be "ARS-long" rather than "ARS-short"

On Mon, 2018-12-03 at 10:30 -0800, Dan Williams wrote:
> A "short" ARS (address range scrub) instructs the platform firmware
> to
> return known errors. In contrast, a "long" ARS instructs platform
> firmware to arrange every data address on the DIMM to be read /
> checked
> for poisoned data.
>
> The conversion of the flags in commit d3abaf43bab8 "acpi, nfit: Fix
> Address Range Scrub completion tracking", changed the meaning of
> passing
> '0' to acpi_nfit_ars_rescan(). Previously '0' meant "not short", now
> '0'
> is ARS_REQ_SHORT. Pass ARS_REQ_LONG to restore the expected scrub-
> type
> behavior of user-initiated ARS sessions.
>
> Fixes: d3abaf43bab8 ("acpi, nfit: Fix Address Range Scrub completion
> tracking")
> Reported-by: Jacek Zloch <[email protected]>
> Cc: Vishal Verma <[email protected]>
> Signed-off-by: Dan Williams <[email protected]>
> ---
> drivers/acpi/nfit/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Looks good,
Reviewed-by: Vishal Verma <[email protected]>

>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 14d9f5bea015..5912d30020c7 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1308,7 +1308,7 @@ static ssize_t scrub_store(struct device *dev,
> if (nd_desc) {
> struct acpi_nfit_desc *acpi_desc =
> to_acpi_desc(nd_desc);
>
> - rc = acpi_nfit_ars_rescan(acpi_desc, 0);
> + rc = acpi_nfit_ars_rescan(acpi_desc, ARS_REQ_LONG);
> }
> device_unlock(dev);
> if (rc)
>