2019-05-21 15:03:23

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH 1/3] dt-bindings: clk: meson: add g12b periph clock controller bindings

Update the documentation to support clock driver for the Amlogic G12B SoC.

G12B clock driver is very close, the main differences are :
- the clock tree is duplicated for the both clusters, and the
SYS_PLL are swapped between the clusters
- G12A has additional clocks like for CSI an other components

Signed-off-by: Neil Armstrong <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
index 5c8b105be4d6..6eaa52092313 100644
--- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
+++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
@@ -10,6 +10,7 @@ Required Properties:
"amlogic,gxl-clkc" for GXL and GXM SoC,
"amlogic,axg-clkc" for AXG SoC.
"amlogic,g12a-clkc" for G12A SoC.
+ "amlogic,g12b-clkc" for G12B SoC.
- clocks : list of clock phandle, one for each entry clock-names.
- clock-names : should contain the following:
* "xtal": the platform xtal
--
2.21.0



2019-05-21 17:32:24

by Martin Blumenstingl

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: clk: meson: add g12b periph clock controller bindings

On Tue, May 21, 2019 at 5:02 PM Neil Armstrong <[email protected]> wrote:
>
> Update the documentation to support clock driver for the Amlogic G12B SoC.
>
> G12B clock driver is very close, the main differences are :
> - the clock tree is duplicated for the both clusters, and the
> SYS_PLL are swapped between the clusters
> - G12A has additional clocks like for CSI an other components
I missed this in v1, it should be G12B?

>
> Signed-off-by: Neil Armstrong <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
with above typo fixed (assuming it is one):
Reviewed-by: Martin Blumenstingl <[email protected]>

2019-05-22 07:45:18

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: clk: meson: add g12b periph clock controller bindings

On 21/05/2019 19:30, Martin Blumenstingl wrote:
> On Tue, May 21, 2019 at 5:02 PM Neil Armstrong <[email protected]> wrote:
>>
>> Update the documentation to support clock driver for the Amlogic G12B SoC.
>>
>> G12B clock driver is very close, the main differences are :
>> - the clock tree is duplicated for the both clusters, and the
>> SYS_PLL are swapped between the clusters
>> - G12A has additional clocks like for CSI an other components
> I missed this in v1, it should be G12B?

Yes, thanks for spotting this

>
>>
>> Signed-off-by: Neil Armstrong <[email protected]>
>> Reviewed-by: Rob Herring <[email protected]>
> with above typo fixed (assuming it is one):
> Reviewed-by: Martin Blumenstingl <[email protected]>
>