2023-06-09 06:54:45

by HaoTien Hsu

Subject: [PATCH v3] phy: tegra: xusb: Clear the driver reference in usb-phy dev

From: EJ Hsu <[email protected]>

For the dual-role port, it will assign the phy dev to usb-phy dev and
use the port dev driver as the dev driver of usb-phy.

When we try to destroy the port dev, it will destroy its dev driver
as well. But we did not remove the reference from usb-phy dev. This
might cause the use-after-free issue in KASAN.

Fixes: e8f7d2f409a1 ("phy: tegra: xusb: Add usb-phy support")
Cc: [email protected]

Signed-off-by: EJ Hsu <[email protected]>
Signed-off-by: Haotien Hsu <[email protected]>
Acked-by: Thierry Reding <[email protected]>
Acked-by: Jon Hunter <[email protected]>
---
V1 -> V2: Remove extra movements to clarify the change
V2 -> V3: Update patch title
---
drivers/phy/tegra/xusb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index 78045bd6c214..26b66a668f3b 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -568,6 +568,7 @@ static void tegra_xusb_port_unregister(struct tegra_xusb_port *port)
usb_role_switch_unregister(port->usb_role_sw);
cancel_work_sync(&port->usb_phy_work);
usb_remove_phy(&port->usb_phy);
+ port->usb_phy.dev->driver = NULL;
}

if (port->ops->remove)
--
2.25.1

2023-06-20 14:18:05

by Jon Hunter

Subject: Re: [PATCH v3] phy: tegra: xusb: Clear the driver reference in usb-phy dev

Hi Vinod,

On 09/06/2023 07:29, Haotien Hsu wrote:
> From: EJ Hsu <[email protected]>
>
> For the dual-role port, it will assign the phy dev to usb-phy dev and
> use the port dev driver as the dev driver of usb-phy.
>
> When we try to destroy the port dev, it will destroy its dev driver
> as well. But we did not remove the reference from usb-phy dev. This
> might cause the use-after-free issue in KASAN.
>
> Fixes: e8f7d2f409a1 ("phy: tegra: xusb: Add usb-phy support")
> Cc: [email protected]
>
> Signed-off-by: EJ Hsu <[email protected]>
> Signed-off-by: Haotien Hsu <[email protected]>
> Acked-by: Thierry Reding <[email protected]>
> Acked-by: Jon Hunter <[email protected]>
> ---
> V1 -> V2: Remove extra movements to clarify the change
> V2 -> V3: Update patch title
> ---
> drivers/phy/tegra/xusb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index 78045bd6c214..26b66a668f3b 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -568,6 +568,7 @@ static void tegra_xusb_port_unregister(struct tegra_xusb_port *port)
> usb_role_switch_unregister(port->usb_role_sw);
> cancel_work_sync(&port->usb_phy_work);
> usb_remove_phy(&port->usb_phy);
> + port->usb_phy.dev->driver = NULL;
> }
>
> if (port->ops->remove)


OK to pick this up now?

Thanks
Jon

--
nvpublic

2023-06-21 12:30:58

by Vinod Koul

Subject: Re: [PATCH v3] phy: tegra: xusb: Clear the driver reference in usb-phy dev

On 09-06-23, 14:29, Haotien Hsu wrote:
> From: EJ Hsu <[email protected]>
>
> For the dual-role port, it will assign the phy dev to usb-phy dev and
> use the port dev driver as the dev driver of usb-phy.
>
> When we try to destroy the port dev, it will destroy its dev driver
> as well. But we did not remove the reference from usb-phy dev. This
> might cause the use-after-free issue in KASAN.

Applied, thanks

--
~Vinod