2020-10-01 21:20:27

by Doug Anderson

Subject: [PATCH] arm64: dts: qcom: sc7180: Fix one forgotten interconnect reference

In commit e23b1220a246 ("arm64: dts: qcom: sc7180: Increase the number
of interconnect cells") we missed increasing the cells on one
interconnect. That's no bueno. Fix it.

NOTE: it appears that things aren't totally broken without this fix,
but clearly something isn't going to be working right. If nothing
else, without this fix I see this in the logs:

OF: /soc@0/mdss@ae00000: could not get #interconnect-cells for /soc@0/interrupt-controller@17a00000

Fixes: e23b1220a246 ("arm64: dts: qcom: sc7180: Increase the number of interconnect cells")
Signed-off-by: Douglas Anderson <[email protected]>
---

arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 6678f1e8e395..a02776ce77a1 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -2811,7 +2811,7 @@ mdss: mdss@ae00000 {
interrupt-controller;
#interrupt-cells = <1>;

- interconnects = <&mmss_noc MASTER_MDP0 &mc_virt SLAVE_EBI1>;
+ interconnects = <&mmss_noc MASTER_MDP0 0 &mc_virt SLAVE_EBI1 0>;
interconnect-names = "mdp0-mem";

iommus = <&apps_smmu 0x800 0x2>;
--
2.28.0.709.gb0816b6eb0-goog

2020-10-02 16:21:56

by Georgi Djakov

Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Fix one forgotten interconnect reference

Thanks for the patch!

On 10/2/20 00:18, Douglas Anderson wrote:
> In commit e23b1220a246 ("arm64: dts: qcom: sc7180: Increase the number
> of interconnect cells") we missed increasing the cells on one
> interconnect. That's no bueno. Fix it.
>
> NOTE: it appears that things aren't totally broken without this fix,
> but clearly something isn't going to be working right. If nothing
> else, without this fix I see this in the logs:
>
> OF: /soc@0/mdss@ae00000: could not get #interconnect-cells for /soc@0/interrupt-controller@17a00000
>
> Fixes: e23b1220a246 ("arm64: dts: qcom: sc7180: Increase the number of interconnect cells")
> Signed-off-by: Douglas Anderson <[email protected]>

Reviewed-by: Georgi Djakov <[email protected]>

BR,
Georgi