2023-06-14 02:37:25

by Jiapeng Chong

Subject: [PATCH] security: keys: Modify mismatched function name

No functional modification involved.

security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting prototype for tpm_buf_append_auth(). Prototype was for tpm2_buf_append_auth() instead.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5524
Signed-off-by: Jiapeng Chong <[email protected]>
---
security/keys/trusted-keys/trusted_tpm2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/keys/trusted-keys/trusted_tpm2.c b/security/keys/trusted-keys/trusted_tpm2.c
index 2b2c8eb258d5..bc700f85f80b 100644
--- a/security/keys/trusted-keys/trusted_tpm2.c
+++ b/security/keys/trusted-keys/trusted_tpm2.c
@@ -186,7 +186,7 @@ int tpm2_key_priv(void *context, size_t hdrlen,
}

/**
- * tpm_buf_append_auth() - append TPMS_AUTH_COMMAND to the buffer.
+ * tpm2_buf_append_auth() - append TPMS_AUTH_COMMAND to the buffer.
*
* @buf: an allocated tpm_buf instance
* @session_handle: session handle
--
2.20.1.7.g153144c

2023-06-14 22:50:22

by Paul Moore

Subject: Re: [PATCH] security: keys: Modify mismatched function name

On Tue, Jun 13, 2023 at 10:18 PM Jiapeng Chong
<[email protected]> wrote:
>
> No functional modification involved.
>
> security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting prototype for tpm_buf_append_auth(). Prototype was for tpm2_buf_append_auth() instead.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5524
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> security/keys/trusted-keys/trusted_tpm2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Paul Moore <[email protected]>

--
paul-moore.com

2023-07-10 19:48:28

by Jarkko Sakkinen

Subject: Re: [PATCH] security: keys: Modify mismatched function name

On Wed, 2023-06-14 at 17:52 -0400, Paul Moore wrote:
> On Tue, Jun 13, 2023 at 10:18 PM Jiapeng Chong
> <[email protected]> wrote:
> >
> > No functional modification involved.
> >
> > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting prototype for tpm_buf_append_auth(). Prototype was for tpm2_buf_append_auth() instead.
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5524
> > Signed-off-by: Jiapeng Chong <[email protected]>
> > ---
> > security/keys/trusted-keys/trusted_tpm2.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Paul Moore <[email protected]>
>

Thanks, I'll pick this.

BR, Jarkko