Subject: [PATCH v4 0/2] Patches for introducing traces in remoteproc.

V4: Add config symbol REMOTEPROC_TRACEPOINTS to enable traces
Rename rproc_qcom.h to remoteproc_tracepoints.h
Rename qcom_tracepoints.c to remoteproc_tracepoints.c
Switch to EXPORT_SYMBOL_GPL

V3: Split the Patch to 2 as per suggestion from Mukesh, fixed format
error from v2.

V2: Moved the traces to common code from the qcom_pas driver as per
Bjorns review, fixed text as per Triloks suggestion, Updated QuiC
copyright to 2023.

[1]: https://lore.kernel.org/all/[email protected]/

Gokul krishna Krishnakumar (2):
remoteproc: Introduce traces for remoteproc events
remoteproc: qcom: Add remoteproc tracing

drivers/remoteproc/Kconfig | 5 +
drivers/remoteproc/Makefile | 1 +
drivers/remoteproc/qcom_common.c | 37 +++++
drivers/remoteproc/qcom_q6v5.c | 9 ++
drivers/remoteproc/remoteproc_core.c | 8 ++
drivers/remoteproc/remoteproc_tracepoints.c | 13 ++
include/trace/events/remoteproc_tracepoints.h | 129 ++++++++++++++++++
7 files changed, 202 insertions(+)
create mode 100644 drivers/remoteproc/remoteproc_tracepoints.c
create mode 100644 include/trace/events/remoteproc_tracepoints.h

--
2.40.1



Subject: Re: [PATCH v4 0/2] Patches for introducing traces in remoteproc.



On 5/31/2023 2:36 PM, Trilok Soni wrote:
> On 5/31/2023 2:35 PM, Trilok Soni wrote:
>> On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote:
>>> V4: Add config symbol REMOTEPROC_TRACEPOINTS to enable traces
>>>      Rename rproc_qcom.h to remoteproc_tracepoints.h
>>>      Rename qcom_tracepoints.c to remoteproc_tracepoints.c
>>>      Switch to EXPORT_SYMBOL_GPL
>>
>>
>> Any reasons you have not sent these patches to mailing list?
>
> I don't see linux-arm-msm mailing list. Are you CCing all the required
> lists and maintainers?
>
> ---Trilok Soni
linux-arm-msm was not in the remoteproc lists(I have included everyone
required), I will include the linux-trace-kernel as well from the next
patch.

Thanks,
Gokul

2023-05-31 21:53:47

by Trilok Soni

[permalink] [raw]
Subject: Re: [PATCH v4 0/2] Patches for introducing traces in remoteproc.

On 5/31/2023 2:49 PM, Gokul Krishna Krishnakumar wrote:
>
>
> On 5/31/2023 2:36 PM, Trilok Soni wrote:
>> On 5/31/2023 2:35 PM, Trilok Soni wrote:
>>> On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote:
>>>> V4: Add config symbol REMOTEPROC_TRACEPOINTS to enable traces
>>>>      Rename rproc_qcom.h to remoteproc_tracepoints.h
>>>>      Rename qcom_tracepoints.c to remoteproc_tracepoints.c
>>>>      Switch to EXPORT_SYMBOL_GPL
>>>
>>>
>>> Any reasons you have not sent these patches to mailing list?
>>
>> I don't see linux-arm-msm mailing list. Are you CCing all the required
>> lists and maintainers?
>>
>> ---Trilok Soni
> linux-arm-msm was not in the remoteproc lists(I have included everyone
> required), I will include the linux-trace-kernel as well from the next
> patch.

Thanks. linux-arm-msm should be default if you had used Qualcomm
platform to test these patches which I am sure you did :)

---Trilok Soni

2023-05-31 22:02:24

by Trilok Soni

[permalink] [raw]
Subject: Re: [PATCH v4 0/2] Patches for introducing traces in remoteproc.

On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote:
> V4: Add config symbol REMOTEPROC_TRACEPOINTS to enable traces
> Rename rproc_qcom.h to remoteproc_tracepoints.h
> Rename qcom_tracepoints.c to remoteproc_tracepoints.c
> Switch to EXPORT_SYMBOL_GPL


Any reasons you have not sent these patches to mailing list?

>
> V3: Split the Patch to 2 as per suggestion from Mukesh, fixed format
> error from v2.
>
> V2: Moved the traces to common code from the qcom_pas driver as per
> Bjorns review, fixed text as per Triloks suggestion, Updated QuiC
> copyright to 2023.
>
> [1]: https://lore.kernel.org/all/[email protected]/
>
> Gokul krishna Krishnakumar (2):
> remoteproc: Introduce traces for remoteproc events
> remoteproc: qcom: Add remoteproc tracing
>
> drivers/remoteproc/Kconfig | 5 +
> drivers/remoteproc/Makefile | 1 +
> drivers/remoteproc/qcom_common.c | 37 +++++
> drivers/remoteproc/qcom_q6v5.c | 9 ++
> drivers/remoteproc/remoteproc_core.c | 8 ++
> drivers/remoteproc/remoteproc_tracepoints.c | 13 ++
> include/trace/events/remoteproc_tracepoints.h | 129 ++++++++++++++++++
> 7 files changed, 202 insertions(+)
> create mode 100644 drivers/remoteproc/remoteproc_tracepoints.c
> create mode 100644 include/trace/events/remoteproc_tracepoints.h
>

2023-05-31 22:28:57

by Trilok Soni

[permalink] [raw]
Subject: Re: [PATCH v4 0/2] Patches for introducing traces in remoteproc.

On 5/31/2023 2:35 PM, Trilok Soni wrote:
> On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote:
>> V4: Add config symbol REMOTEPROC_TRACEPOINTS to enable traces
>>      Rename rproc_qcom.h to remoteproc_tracepoints.h
>>      Rename qcom_tracepoints.c to remoteproc_tracepoints.c
>>      Switch to EXPORT_SYMBOL_GPL
>
>
> Any reasons you have not sent these patches to mailing list?

I don't see linux-arm-msm mailing list. Are you CCing all the required
lists and maintainers?

---Trilok Soni