2019-04-16 17:26:17

by Moses Christopher

Subject: [PATCH] clocksource: timer-probe: change log level to warn

- In drivers/clocksource/timer-probe.c, the log level for the message
stating "no matching timers found" should be of warning(4) rather
than critical(2)
- Reference:
- https://e2e.ti.com/support/processors/f/791/t/726024
- As per the feedback received from Daniel Lezcano

Signed-off-by: Moses Christopher <[email protected]>
---
drivers/clocksource/timer-probe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-probe.c b/drivers/clocksource/timer-probe.c
index 028075720334..246b45d22d08 100644
--- a/drivers/clocksource/timer-probe.c
+++ b/drivers/clocksource/timer-probe.c
@@ -50,5 +50,5 @@ void __init timer_probe(void)
timers += acpi_probe_device_table(timer);

if (!timers)
- pr_crit("%s: no matching timers found\n", __func__);
+ pr_warn("%s: no matching timers found\n", __func__);
}
--
2.17.1

2019-04-16 17:34:41

by Daniel Lezcano

Subject: Re: [PATCH] clocksource: timer-probe: change log level to warn

On 16/04/2019 19:23, Moses Christopher wrote:
> - In drivers/clocksource/timer-probe.c, the log level for the message
> stating "no matching timers found" should be of warning(4) rather
> than critical(2)
> - Reference:
> - https://e2e.ti.com/support/processors/f/791/t/726024
> - As per the feedback received from Daniel Lezcano
>
> Signed-off-by: Moses Christopher <[email protected]>

Applied for 5.2 but massaged a bit the change log to comply with the
kernel submitting patches rules.

> ---
> drivers/clocksource/timer-probe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-probe.c b/drivers/clocksource/timer-probe.c
> index 028075720334..246b45d22d08 100644
> --- a/drivers/clocksource/timer-probe.c
> +++ b/drivers/clocksource/timer-probe.c
> @@ -50,5 +50,5 @@ void __init timer_probe(void)
> timers += acpi_probe_device_table(timer);
>
> if (!timers)
> - pr_crit("%s: no matching timers found\n", __func__);
> + pr_warn("%s: no matching timers found\n", __func__);
> }
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog