2023-02-14 13:19:24

by Arnd Bergmann

Subject: [PATCH] dax/hmem: build hmem device support as module if possible

From: Arnd Bergmann <[email protected]>

When device_hmem.o is enabled but dax itself is a loadable module, the
dax_hmem support fails to link because Kbuild never compiles built-in
code under drivers/dax:

ERROR: modpost: "walk_hmem_resources" [drivers/dax/hmem/dax_hmem.ko] undefined!

Make sure that drivers/dax is entered for compiling built-in code
even with CONFIG_DAX=m.

Fixes: 7dab174e2e27 ("dax/hmem: Move hmem device registration to dax_hmem.ko")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/Makefile b/drivers/Makefile
index 148ccfc2b5fe..20b118dca999 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -76,7 +76,7 @@ obj-$(CONFIG_FB_INTEL) += video/fbdev/intelfb/
obj-$(CONFIG_PARPORT) += parport/
obj-y += base/ block/ misc/ mfd/ nfc/
obj-$(CONFIG_LIBNVDIMM) += nvdimm/
-obj-$(CONFIG_DAX) += dax/
+obj-y += dax/
obj-$(CONFIG_DMA_SHARED_BUFFER) += dma-buf/
obj-$(CONFIG_NUBUS) += nubus/
obj-y += cxl/
--
2.39.1

2023-02-14 16:41:16

by Dan Williams

Subject: RE: [PATCH] dax/hmem: build hmem device support as module if possible

Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> When device_hmem.o is enabled but dax itself is a loadable module, the
> dax_hmem support fails to link because Kbuild never compiles built-in
> code under drivers/dax:
>
> ERROR: modpost: "walk_hmem_resources" [drivers/dax/hmem/dax_hmem.ko] undefined!
>
> Make sure that drivers/dax is entered for compiling built-in code
> even with CONFIG_DAX=m.
>
> Fixes: 7dab174e2e27 ("dax/hmem: Move hmem device registration to dax_hmem.ko")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---

Thanks, applied.