2021-07-09 02:51:47

by Souptick Joarder

Subject: [PATCH] drm/msm/dp: Remove unused variable

Kernel test roobot throws below warning ->

drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
warning: variable 'drm' set but not used [-Wunused-but-set-variable]

Removed unused variable drm.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Souptick Joarder <[email protected]>
---
drivers/gpu/drm/msm/dp/dp_display.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 051c1be1de7e..d42635a86d20 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -1014,10 +1014,8 @@ int dp_display_get_test_bpp(struct msm_dp *dp)
void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp *dp)
{
struct dp_display_private *dp_display;
- struct drm_device *drm;

dp_display = container_of(dp, struct dp_display_private, dp_display);
- drm = dp->drm_dev;

/*
* if we are reading registers we need the link clocks to be on
--
2.25.1

2021-07-09 03:13:21

by Abhinav Kumar

Subject: Re: [Freedreno] [PATCH] drm/msm/dp: Remove unused variable

On 2021-07-08 19:48, Souptick Joarder wrote:
> Kernel test roobot throws below warning ->
>
> drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
> warning: variable 'drm' set but not used [-Wunused-but-set-variable]
>
> Removed unused variable drm.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Souptick Joarder <[email protected]>
Reviewed-by: Abhinav Kumar <[email protected]>
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
> b/drivers/gpu/drm/msm/dp/dp_display.c
> index 051c1be1de7e..d42635a86d20 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -1014,10 +1014,8 @@ int dp_display_get_test_bpp(struct msm_dp *dp)
> void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp
> *dp)
> {
> struct dp_display_private *dp_display;
> - struct drm_device *drm;
>
> dp_display = container_of(dp, struct dp_display_private, dp_display);
> - drm = dp->drm_dev;
>
> /*
> * if we are reading registers we need the link clocks to be on

2021-07-14 23:15:46

by Stephen Boyd

Subject: Re: [PATCH] drm/msm/dp: Remove unused variable

Quoting Souptick Joarder (2021-07-08 19:48:34)
> Kernel test roobot throws below warning ->
>
> drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
> warning: variable 'drm' set but not used [-Wunused-but-set-variable]
>
> Removed unused variable drm.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Souptick Joarder <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2021-08-02 14:48:09

by Souptick Joarder

Subject: Re: [PATCH] drm/msm/dp: Remove unused variable

On Thu, Jul 15, 2021 at 3:09 AM Stephen Boyd <[email protected]> wrote:
>
> Quoting Souptick Joarder (2021-07-08 19:48:34)
> > Kernel test roobot throws below warning ->
> >
> > drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
> > warning: variable 'drm' set but not used [-Wunused-but-set-variable]
> >
> > Removed unused variable drm.
> >

Can we get this in queue for 5.15, if no further comment ?


> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Souptick Joarder <[email protected]>
> > ---
>
> Reviewed-by: Stephen Boyd <[email protected]>