2007-09-09 19:03:06

by Matti Linnanvuori

Subject: [PATCH] [Bug 8998] Mutex documentation is unclear about software interrupts, tasklets and timers in Linux 2.6.23-rc

diff -uprN linux-2.6.23/Documentation/mutex-design.txt linux-2.6.23-patched/Documentation/mutex-design.txt
--- linux-2.6.23/Documentation/mutex-design.txt 2007-09-09 21:47:10.545275000 +0300
+++ linux-2.6.23-patched/Documentation/mutex-design.txt 2007-09-09 21:48:17.935493000 +0300
@@ -90,7 +90,8 @@ of advantages of mutexes:
* - task may not exit with mutex held
* - memory areas where held locks reside must not be freed
* - held mutexes must not be reinitialized
- * - mutexes may not be used in irq contexts
+ * - mutexes may not be used in hardware or software interrupt
+ * contexts such as tasklets and timers

furthermore, there are also convenience features in the debugging
code:
diff -uprN linux-2.6.23/include/linux/mutex.h linux-2.6.23-patched/include/linux/mutex.h
--- linux-2.6.23/include/linux/mutex.h 2007-09-09 21:49:04.531143500 +0300
+++ linux-2.6.23-patched/include/linux/mutex.h 2007-09-09 21:49:44.946525500 +0300
@@ -29,7 +29,8 @@
* - task may not exit with mutex held
* - memory areas where held locks reside must not be freed
* - held mutexes must not be reinitialized
- * - mutexes may not be used in irq contexts
+ * - mutexes may not be used in hardware or software interrupt
+ * contexts such as tasklets and timers
*
* These semantics are fully enforced when DEBUG_MUTEXES is
* enabled. Furthermore, besides enforcing the above rules, the mutex



Signed-off-by: Matti Linnanvuori <[email protected]>




__________________________________
Kennt man wirklich jeden ?ber 3 Ecken? Die Antworten gibt's bei Yahoo! Clever. http://www.yahoo.de/clever

2007-09-09 19:08:01

by Arjan van de Ven

Subject: Re: [PATCH] [Bug 8998] Mutex documentation is unclear about software interrupts, tasklets and timers in Linux 2.6.23-rc

On Sun, 9 Sep 2007 12:02:53 -0700 (PDT)
Matti Linnanvuori <[email protected]> wrote:

Hi,

thank you for improving the documentation


> diff -uprN linux-2.6.23/Documentation/mutex-design.txt
> linux-2.6.23-patched/Documentation/mutex-design.txt ---
>
>
> Signed-off-by: Matti Linnanvuori <[email protected]>
>

Acked-by: Arjan van de Ven <[email protected]>