2019-10-25 18:50:18

by James Smart

[permalink] [raw]
Subject: Re: [PATCH] scsi: lpfc: lpfc_attr.c: Fix Use plain integer as NULL pointer

On 10/23/2019 7:57 PM, Saurav Girepunje wrote:
> Replace assignment of 0 to pointer with NULL assignment.
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
> drivers/scsi/lpfc/lpfc_attr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
> index ea62322ffe2b..f7df95963a63 100644
> --- a/drivers/scsi/lpfc/lpfc_attr.c
> +++ b/drivers/scsi/lpfc/lpfc_attr.c
> @@ -1641,7 +1641,7 @@ lpfc_set_trunking(struct lpfc_hba *phba, char *buff_out)
> {
> LPFC_MBOXQ_t *mbox = NULL;
> unsigned long val = 0;
> - char *pval = 0;
> + char *pval = NULL;
> int rc = 0;
>
> if (!strncmp("enable", buff_out,

thanks

Reviewed-by: James Smart <[email protected]>

-- james