2021-03-15 03:24:39

by Bhaskar Chowdhury

[permalink] [raw]
Subject: [PATCH V2] drm: amd: pm: Mundane typo fixes in the file amdgpu_pm.c


s/"an minimum"/"a minimum"/
s/"an maxmum"/"a maximum"/

Signed-off-by: Bhaskar Chowdhury <[email protected]>
---
Changes from V1:
Randy's suggestion to adjust the subject line text
And missed out a spell too,which now included

drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 5fa65f191a37..308249ae1a22 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -3315,9 +3315,9 @@ static ssize_t amdgpu_hwmon_show_mclk_label(struct device *dev,
*
* - pwm1_max: pulse width modulation fan control maximum level (255)
*
- * - fan1_min: an minimum value Unit: revolution/min (RPM)
+ * - fan1_min: a minimum value Unit: revolution/min (RPM)
*
- * - fan1_max: an maxmum value Unit: revolution/max (RPM)
+ * - fan1_max: a maximum value Unit: revolution/max (RPM)
*
* - fan1_input: fan speed in RPM
*
--
2.30.2


2021-03-15 03:50:17

by Huang Rui

[permalink] [raw]
Subject: Re: [PATCH V2] drm: amd: pm: Mundane typo fixes in the file amdgpu_pm.c

On Mon, Mar 15, 2021 at 11:21:36AM +0800, Bhaskar Chowdhury wrote:
>
> s/"an minimum"/"a minimum"/
> s/"an maxmum"/"a maximum"/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>

Reviewed-by: Huang Rui <[email protected]>

> ---
> Changes from V1:
> Randy's suggestion to adjust the subject line text
> And missed out a spell too,which now included
>
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 5fa65f191a37..308249ae1a22 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -3315,9 +3315,9 @@ static ssize_t amdgpu_hwmon_show_mclk_label(struct device *dev,
> *
> * - pwm1_max: pulse width modulation fan control maximum level (255)
> *
> - * - fan1_min: an minimum value Unit: revolution/min (RPM)
> + * - fan1_min: a minimum value Unit: revolution/min (RPM)
> *
> - * - fan1_max: an maxmum value Unit: revolution/max (RPM)
> + * - fan1_max: a maximum value Unit: revolution/max (RPM)
> *
> * - fan1_input: fan speed in RPM
> *
> --
> 2.30.2
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=04%7C01%7Cray.huang%40amd.com%7C7815a224727f4c9b556008d8e76182b4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637513753293707291%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=ApeKXDkijsihPcGSoI9v8ypRcsUXSb2Y7%2FpKsm3c4Xo%3D&amp;reserved=0

2021-03-15 04:20:33

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH V2] drm: amd: pm: Mundane typo fixes in the file amdgpu_pm.c

On 3/14/21 8:21 PM, Bhaskar Chowdhury wrote:
>
> s/"an minimum"/"a minimum"/
> s/"an maxmum"/"a maximum"/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

> ---
> Changes from V1:
> Randy's suggestion to adjust the subject line text
> And missed out a spell too,which now included
>
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 5fa65f191a37..308249ae1a22 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -3315,9 +3315,9 @@ static ssize_t amdgpu_hwmon_show_mclk_label(struct device *dev,
> *
> * - pwm1_max: pulse width modulation fan control maximum level (255)
> *
> - * - fan1_min: an minimum value Unit: revolution/min (RPM)
> + * - fan1_min: a minimum value Unit: revolution/min (RPM)
> *
> - * - fan1_max: an maxmum value Unit: revolution/max (RPM)
> + * - fan1_max: a maximum value Unit: revolution/max (RPM)
> *
> * - fan1_input: fan speed in RPM
> *
> --


--
~Randy

2021-03-15 23:32:14

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH V2] drm: amd: pm: Mundane typo fixes in the file amdgpu_pm.c

On Sun, Mar 14, 2021 at 11:22 PM Bhaskar Chowdhury
<[email protected]> wrote:
>
>
> s/"an minimum"/"a minimum"/
> s/"an maxmum"/"a maximum"/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>

Applied. Thanks!

Alex

> ---
> Changes from V1:
> Randy's suggestion to adjust the subject line text
> And missed out a spell too,which now included
>
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 5fa65f191a37..308249ae1a22 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -3315,9 +3315,9 @@ static ssize_t amdgpu_hwmon_show_mclk_label(struct device *dev,
> *
> * - pwm1_max: pulse width modulation fan control maximum level (255)
> *
> - * - fan1_min: an minimum value Unit: revolution/min (RPM)
> + * - fan1_min: a minimum value Unit: revolution/min (RPM)
> *
> - * - fan1_max: an maxmum value Unit: revolution/max (RPM)
> + * - fan1_max: a maximum value Unit: revolution/max (RPM)
> *
> * - fan1_input: fan speed in RPM
> *
> --
> 2.30.2
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel