If devm_drm_of_get_bridge() can't find the connected bridge, it returns an
ERR_PTR(-EPROBE_DEFER) to indicate that the probe should be deferred.
But this path also prints an error message, which pollutes the kernel log
since is printed on every probe deferral, i.e:
$ dmesg | grep "failed to create panel bridge" | wc -l
38
Signed-off-by: Javier Martinez Canillas <[email protected]>
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index 369bf72717f6..90bbabde1595 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -1206,10 +1206,9 @@ static int ti_sn_bridge_probe(struct auxiliary_device *adev,
int ret;
pdata->next_bridge = devm_drm_of_get_bridge(pdata->dev, np, 1, 0);
- if (IS_ERR(pdata->next_bridge)) {
- DRM_ERROR("failed to create panel bridge\n");
- return PTR_ERR(pdata->next_bridge);
- }
+ if (IS_ERR(pdata->next_bridge))
+ return dev_err_probe(pdata->dev, PTR_ERR(pdata->next_bridge),
+ "failed to create panel bridge\n");
ti_sn_bridge_parse_lanes(pdata, np);
--
2.36.1
On 22/07/2022 09:47, Javier Martinez Canillas wrote:
> If devm_drm_of_get_bridge() can't find the connected bridge, it returns an
> ERR_PTR(-EPROBE_DEFER) to indicate that the probe should be deferred.
>
> But this path also prints an error message, which pollutes the kernel log
> since is printed on every probe deferral, i.e:
>
> $ dmesg | grep "failed to create panel bridge" | wc -l
> 38
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
> ---
>
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index 369bf72717f6..90bbabde1595 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -1206,10 +1206,9 @@ static int ti_sn_bridge_probe(struct auxiliary_device *adev,
> int ret;
>
> pdata->next_bridge = devm_drm_of_get_bridge(pdata->dev, np, 1, 0);
> - if (IS_ERR(pdata->next_bridge)) {
> - DRM_ERROR("failed to create panel bridge\n");
> - return PTR_ERR(pdata->next_bridge);
> - }
> + if (IS_ERR(pdata->next_bridge))
> + return dev_err_probe(pdata->dev, PTR_ERR(pdata->next_bridge),
> + "failed to create panel bridge\n");
>
> ti_sn_bridge_parse_lanes(pdata, np);
>
Reviewed-by: Neil Armstrong <[email protected]>
On 22.07.2022 09:47, Javier Martinez Canillas wrote:
> If devm_drm_of_get_bridge() can't find the connected bridge, it returns an
> ERR_PTR(-EPROBE_DEFER) to indicate that the probe should be deferred.
>
> But this path also prints an error message, which pollutes the kernel log
> since is printed on every probe deferral, i.e:
>
> $ dmesg | grep "failed to create panel bridge" | wc -l
> 38
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
Reviewed-by: Andrzej Hajda <[email protected]>
Regards
Andrzej
> ---
>
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index 369bf72717f6..90bbabde1595 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -1206,10 +1206,9 @@ static int ti_sn_bridge_probe(struct auxiliary_device *adev,
> int ret;
>
> pdata->next_bridge = devm_drm_of_get_bridge(pdata->dev, np, 1, 0);
> - if (IS_ERR(pdata->next_bridge)) {
> - DRM_ERROR("failed to create panel bridge\n");
> - return PTR_ERR(pdata->next_bridge);
> - }
> + if (IS_ERR(pdata->next_bridge))
> + return dev_err_probe(pdata->dev, PTR_ERR(pdata->next_bridge),
> + "failed to create panel bridge\n");
>
> ti_sn_bridge_parse_lanes(pdata, np);
>
Hi,
On Fri, Jul 22, 2022 at 12:48 AM Javier Martinez Canillas
<[email protected]> wrote:
>
> If devm_drm_of_get_bridge() can't find the connected bridge, it returns an
> ERR_PTR(-EPROBE_DEFER) to indicate that the probe should be deferred.
>
> But this path also prints an error message, which pollutes the kernel log
> since is printed on every probe deferral, i.e:
>
> $ dmesg | grep "failed to create panel bridge" | wc -l
> 38
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
> ---
>
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Douglas Anderson <[email protected]>
If someone else doesn't beat me to it, I'll apply next week sometime.
On 7/22/22 15:35, Doug Anderson wrote:
> Hi,
>
> On Fri, Jul 22, 2022 at 12:48 AM Javier Martinez Canillas
> <[email protected]> wrote:
>>
>> If devm_drm_of_get_bridge() can't find the connected bridge, it returns an
>> ERR_PTR(-EPROBE_DEFER) to indicate that the probe should be deferred.
>>
>> But this path also prints an error message, which pollutes the kernel log
>> since is printed on every probe deferral, i.e:
>>
>> $ dmesg | grep "failed to create panel bridge" | wc -l
>> 38
>>
>> Signed-off-by: Javier Martinez Canillas <[email protected]>
>> ---
>>
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> Reviewed-by: Douglas Anderson <[email protected]>
>
> If someone else doesn't beat me to it, I'll apply next week sometime.
>
I've pushed this to drm-misc (drm-misc-next). Thanks all!
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat