Hi Robert,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
head: b9f174a70c6f609b6132c3a65883b16d552984b8
commit: 8b8ad8a7ac24905937c3975b54c4594b93b66ebb [1539/3265] net: axienet: Wait for PhyRstCmplt after core reset
config: microblaze-randconfig-r003-20220704 (https://download.01.org/0day-ci/archive/20220706/[email protected]/config)
compiler: microblaze-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=8b8ad8a7ac24905937c3975b54c4594b93b66ebb
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-4.19.y
git checkout 8b8ad8a7ac24905937c3975b54c4594b93b66ebb
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/net/ethernet/xilinx/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
drivers/net/ethernet/xilinx/xilinx_axienet_main.c: In function 'axienet_dma_bd_init':
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9: error: 'ret' undeclared (first use in this function); did you mean 'net'?
283 | ret = read_poll_timeout(axienet_ior, value,
| ^~~
| net
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:15: error: implicit declaration of function 'read_poll_timeout' [-Werror=implicit-function-declaration]
283 | ret = read_poll_timeout(axienet_ior, value,
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:46: error: 'value' undeclared (first use in this function)
283 | ret = read_poll_timeout(axienet_ior, value,
| ^~~~~
cc1: some warnings being treated as errors
vim +/read_poll_timeout +283 drivers/net/ethernet/xilinx/xilinx_axienet_main.c
178
179 /**
180 * axienet_dma_bd_init - Setup buffer descriptor rings for Axi DMA
181 * @ndev: Pointer to the net_device structure
182 *
183 * Return: 0, on success -ENOMEM, on failure
184 *
185 * This function is called to initialize the Rx and Tx DMA descriptor
186 * rings. This initializes the descriptors with required default values
187 * and is called when Axi Ethernet driver reset is called.
188 */
189 static int axienet_dma_bd_init(struct net_device *ndev)
190 {
191 u32 cr;
192 int i;
193 struct sk_buff *skb;
194 struct axienet_local *lp = netdev_priv(ndev);
195
196 /* Reset the indexes which are used for accessing the BDs */
197 lp->tx_bd_ci = 0;
198 lp->tx_bd_tail = 0;
199 lp->rx_bd_ci = 0;
200
201 /* Allocate the Tx and Rx buffer descriptors. */
202 lp->tx_bd_v = dma_zalloc_coherent(ndev->dev.parent,
203 sizeof(*lp->tx_bd_v) * TX_BD_NUM,
204 &lp->tx_bd_p, GFP_KERNEL);
205 if (!lp->tx_bd_v)
206 goto out;
207
208 lp->rx_bd_v = dma_zalloc_coherent(ndev->dev.parent,
209 sizeof(*lp->rx_bd_v) * RX_BD_NUM,
210 &lp->rx_bd_p, GFP_KERNEL);
211 if (!lp->rx_bd_v)
212 goto out;
213
214 for (i = 0; i < TX_BD_NUM; i++) {
215 lp->tx_bd_v[i].next = lp->tx_bd_p +
216 sizeof(*lp->tx_bd_v) *
217 ((i + 1) % TX_BD_NUM);
218 }
219
220 for (i = 0; i < RX_BD_NUM; i++) {
221 lp->rx_bd_v[i].next = lp->rx_bd_p +
222 sizeof(*lp->rx_bd_v) *
223 ((i + 1) % RX_BD_NUM);
224
225 skb = netdev_alloc_skb_ip_align(ndev, lp->max_frm_size);
226 if (!skb)
227 goto out;
228
229 lp->rx_bd_v[i].sw_id_offset = (u32) skb;
230 lp->rx_bd_v[i].phys = dma_map_single(ndev->dev.parent,
231 skb->data,
232 lp->max_frm_size,
233 DMA_FROM_DEVICE);
234 lp->rx_bd_v[i].cntrl = lp->max_frm_size;
235 }
236
237 /* Start updating the Rx channel control register */
238 cr = axienet_dma_in32(lp, XAXIDMA_RX_CR_OFFSET);
239 /* Update the interrupt coalesce count */
240 cr = ((cr & ~XAXIDMA_COALESCE_MASK) |
241 ((lp->coalesce_count_rx) << XAXIDMA_COALESCE_SHIFT));
242 /* Update the delay timer count */
243 cr = ((cr & ~XAXIDMA_DELAY_MASK) |
244 (XAXIDMA_DFT_RX_WAITBOUND << XAXIDMA_DELAY_SHIFT));
245 /* Enable coalesce, delay timer and error interrupts */
246 cr |= XAXIDMA_IRQ_ALL_MASK;
247 /* Write to the Rx channel control register */
248 axienet_dma_out32(lp, XAXIDMA_RX_CR_OFFSET, cr);
249
250 /* Start updating the Tx channel control register */
251 cr = axienet_dma_in32(lp, XAXIDMA_TX_CR_OFFSET);
252 /* Update the interrupt coalesce count */
253 cr = (((cr & ~XAXIDMA_COALESCE_MASK)) |
254 ((lp->coalesce_count_tx) << XAXIDMA_COALESCE_SHIFT));
255 /* Update the delay timer count */
256 cr = (((cr & ~XAXIDMA_DELAY_MASK)) |
257 (XAXIDMA_DFT_TX_WAITBOUND << XAXIDMA_DELAY_SHIFT));
258 /* Enable coalesce, delay timer and error interrupts */
259 cr |= XAXIDMA_IRQ_ALL_MASK;
260 /* Write to the Tx channel control register */
261 axienet_dma_out32(lp, XAXIDMA_TX_CR_OFFSET, cr);
262
263 /* Populate the tail pointer and bring the Rx Axi DMA engine out of
264 * halted state. This will make the Rx side ready for reception.
265 */
266 axienet_dma_out32(lp, XAXIDMA_RX_CDESC_OFFSET, lp->rx_bd_p);
267 cr = axienet_dma_in32(lp, XAXIDMA_RX_CR_OFFSET);
268 axienet_dma_out32(lp, XAXIDMA_RX_CR_OFFSET,
269 cr | XAXIDMA_CR_RUNSTOP_MASK);
270 axienet_dma_out32(lp, XAXIDMA_RX_TDESC_OFFSET, lp->rx_bd_p +
271 (sizeof(*lp->rx_bd_v) * (RX_BD_NUM - 1)));
272
273 /* Write to the RS (Run-stop) bit in the Tx channel control register.
274 * Tx channel is now ready to run. But only after we write to the
275 * tail pointer register that the Tx channel will start transmitting.
276 */
277 axienet_dma_out32(lp, XAXIDMA_TX_CDESC_OFFSET, lp->tx_bd_p);
278 cr = axienet_dma_in32(lp, XAXIDMA_TX_CR_OFFSET);
279 axienet_dma_out32(lp, XAXIDMA_TX_CR_OFFSET,
280 cr | XAXIDMA_CR_RUNSTOP_MASK);
281
282 /* Wait for PhyRstCmplt bit to be set, indicating the PHY reset has finished */
> 283 ret = read_poll_timeout(axienet_ior, value,
284 value & XAE_INT_PHYRSTCMPLT_MASK,
285 DELAY_OF_ONE_MILLISEC, 50000, false, lp,
286 XAE_IS_OFFSET);
287 if (ret) {
288 dev_err(lp->dev, "%s: timeout waiting for PhyRstCmplt\n", __func__);
289 return ret;
290 }
291
292 return 0;
293 out:
294 axienet_dma_bd_release(ndev);
295 return -ENOMEM;
296 }
297
--
0-DAY CI Kernel Test Service
https://01.org/lkp
On Wed, 2022-07-06 at 18:43 +0800, kernel test robot wrote:
> Hi Robert,
>
> FYI, the error/warning still remains.
>
> tree:
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas4Ne1iIw$
> linux-4.19.y
> head: b9f174a70c6f609b6132c3a65883b16d552984b8
> commit: 8b8ad8a7ac24905937c3975b54c4594b93b66ebb [1539/3265] net:
> axienet: Wait for PhyRstCmplt after core reset
> config: microblaze-randconfig-r003-20220704
> (https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/
> 20220706/[email protected]/config__;!!IOGos0k!nK_4H
> G5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZatUAT
> tDaQ$ )
> compiler: microblaze-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
> wget
> https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZautG4jkgg$
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> #
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=8b8ad8a7ac24905937c3975b54c4594b93b66ebb__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas8R9M_sA$
>
> git remote add linux-stable-rc
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas4Ne1iIw$
>
> git fetch --no-tags linux-stable-rc linux-4.19.y
> git checkout 8b8ad8a7ac24905937c3975b54c4594b93b66ebb
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0
> make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash
> drivers/net/ethernet/xilinx/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c: In function
> 'axienet_dma_bd_init':
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9: error:
> 'ret' undeclared (first use in this function); did you mean 'net'?
> 283 | ret = read_poll_timeout(axienet_ior, value,
> | ^~~
> | net
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9: note:
> each undeclared identifier is reported only once for each function it
> appears in
> > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:15: error:
> > > implicit declaration of function 'read_poll_timeout' [-
> > > Werror=implicit-function-declaration]
> 283 | ret = read_poll_timeout(axienet_ior, value,
> | ^~~~~~~~~~~~~~~~~
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:46: error:
> 'value' undeclared (first use in this function)
> 283 | ret = read_poll_timeout(axienet_ior, value,
> | ^~~~~
> cc1: some warnings being treated as errors
>
This seems like maybe a bad backport of the listed patch to the 4.19
stable release?
>
> vim +/read_poll_timeout +283
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c
>
> 178
> 179 /**
> 180 * axienet_dma_bd_init - Setup buffer descriptor rings for
> Axi DMA
> 181 * @ndev: Pointer to the net_device structure
> 182 *
> 183 * Return: 0, on success -ENOMEM, on failure
> 184 *
> 185 * This function is called to initialize the Rx and Tx DMA
> descriptor
> 186 * rings. This initializes the descriptors with required
> default values
> 187 * and is called when Axi Ethernet driver reset is called.
> 188 */
> 189 static int axienet_dma_bd_init(struct net_device *ndev)
> 190 {
> 191 u32 cr;
> 192 int i;
> 193 struct sk_buff *skb;
> 194 struct axienet_local *lp = netdev_priv(ndev);
> 195
> 196 /* Reset the indexes which are used for accessing the
> BDs */
> 197 lp->tx_bd_ci = 0;
> 198 lp->tx_bd_tail = 0;
> 199 lp->rx_bd_ci = 0;
> 200
> 201 /* Allocate the Tx and Rx buffer descriptors. */
> 202 lp->tx_bd_v = dma_zalloc_coherent(ndev->dev.parent,
> 203 sizeof(*lp-
> >tx_bd_v) * TX_BD_NUM,
> 204 &lp->tx_bd_p,
> GFP_KERNEL);
> 205 if (!lp->tx_bd_v)
> 206 goto out;
> 207
> 208 lp->rx_bd_v = dma_zalloc_coherent(ndev->dev.parent,
> 209 sizeof(*lp-
> >rx_bd_v) * RX_BD_NUM,
> 210 &lp->rx_bd_p,
> GFP_KERNEL);
> 211 if (!lp->rx_bd_v)
> 212 goto out;
> 213
> 214 for (i = 0; i < TX_BD_NUM; i++) {
> 215 lp->tx_bd_v[i].next = lp->tx_bd_p +
> 216 sizeof(*lp->tx_bd_v) *
> 217 ((i + 1) % TX_BD_NUM);
> 218 }
> 219
> 220 for (i = 0; i < RX_BD_NUM; i++) {
> 221 lp->rx_bd_v[i].next = lp->rx_bd_p +
> 222 sizeof(*lp->rx_bd_v) *
> 223 ((i + 1) % RX_BD_NUM);
> 224
> 225 skb = netdev_alloc_skb_ip_align(ndev, lp-
> >max_frm_size);
> 226 if (!skb)
> 227 goto out;
> 228
> 229 lp->rx_bd_v[i].sw_id_offset = (u32) skb;
> 230 lp->rx_bd_v[i].phys = dma_map_single(ndev-
> >dev.parent,
> 231 skb-
> >data,
> 232 lp-
> >max_frm_size,
> 233
> DMA_FROM_DEVICE);
> 234 lp->rx_bd_v[i].cntrl = lp->max_frm_size;
> 235 }
> 236
> 237 /* Start updating the Rx channel control register */
> 238 cr = axienet_dma_in32(lp, XAXIDMA_RX_CR_OFFSET);
> 239 /* Update the interrupt coalesce count */
> 240 cr = ((cr & ~XAXIDMA_COALESCE_MASK) |
> 241 ((lp->coalesce_count_rx) <<
> XAXIDMA_COALESCE_SHIFT));
> 242 /* Update the delay timer count */
> 243 cr = ((cr & ~XAXIDMA_DELAY_MASK) |
> 244 (XAXIDMA_DFT_RX_WAITBOUND <<
> XAXIDMA_DELAY_SHIFT));
> 245 /* Enable coalesce, delay timer and error interrupts
> */
> 246 cr |= XAXIDMA_IRQ_ALL_MASK;
> 247 /* Write to the Rx channel control register */
> 248 axienet_dma_out32(lp, XAXIDMA_RX_CR_OFFSET, cr);
> 249
> 250 /* Start updating the Tx channel control register */
> 251 cr = axienet_dma_in32(lp, XAXIDMA_TX_CR_OFFSET);
> 252 /* Update the interrupt coalesce count */
> 253 cr = (((cr & ~XAXIDMA_COALESCE_MASK)) |
> 254 ((lp->coalesce_count_tx) <<
> XAXIDMA_COALESCE_SHIFT));
> 255 /* Update the delay timer count */
> 256 cr = (((cr & ~XAXIDMA_DELAY_MASK)) |
> 257 (XAXIDMA_DFT_TX_WAITBOUND <<
> XAXIDMA_DELAY_SHIFT));
> 258 /* Enable coalesce, delay timer and error interrupts
> */
> 259 cr |= XAXIDMA_IRQ_ALL_MASK;
> 260 /* Write to the Tx channel control register */
> 261 axienet_dma_out32(lp, XAXIDMA_TX_CR_OFFSET, cr);
> 262
> 263 /* Populate the tail pointer and bring the Rx Axi DMA
> engine out of
> 264 * halted state. This will make the Rx side ready for
> reception.
> 265 */
> 266 axienet_dma_out32(lp, XAXIDMA_RX_CDESC_OFFSET, lp-
> >rx_bd_p);
> 267 cr = axienet_dma_in32(lp, XAXIDMA_RX_CR_OFFSET);
> 268 axienet_dma_out32(lp, XAXIDMA_RX_CR_OFFSET,
> 269 cr | XAXIDMA_CR_RUNSTOP_MASK);
> 270 axienet_dma_out32(lp, XAXIDMA_RX_TDESC_OFFSET, lp-
> >rx_bd_p +
> 271 (sizeof(*lp->rx_bd_v) * (RX_BD_NUM
> - 1)));
> 272
> 273 /* Write to the RS (Run-stop) bit in the Tx channel
> control register.
> 274 * Tx channel is now ready to run. But only after we
> write to the
> 275 * tail pointer register that the Tx channel will
> start transmitting.
> 276 */
> 277 axienet_dma_out32(lp, XAXIDMA_TX_CDESC_OFFSET, lp-
> >tx_bd_p);
> 278 cr = axienet_dma_in32(lp, XAXIDMA_TX_CR_OFFSET);
> 279 axienet_dma_out32(lp, XAXIDMA_TX_CR_OFFSET,
> 280 cr | XAXIDMA_CR_RUNSTOP_MASK);
> 281
> 282 /* Wait for PhyRstCmplt bit to be set, indicating the
> PHY reset has finished */
> > 283 ret = read_poll_timeout(axienet_ior, value,
> 284 value &
> XAE_INT_PHYRSTCMPLT_MASK,
> 285 DELAY_OF_ONE_MILLISEC, 50000,
> false, lp,
> 286 XAE_IS_OFFSET);
> 287 if (ret) {
> 288 dev_err(lp->dev, "%s: timeout waiting for
> PhyRstCmplt\n", __func__);
> 289 return ret;
> 290 }
> 291
> 292 return 0;
> 293 out:
> 294 axienet_dma_bd_release(ndev);
> 295 return -ENOMEM;
> 296 }
> 297
>
On Wed, Jul 06, 2022 at 10:42:48PM +0000, Robert Hancock wrote:
> On Wed, 2022-07-06 at 18:43 +0800, kernel test robot wrote:
> > Hi Robert,
> >
> > FYI, the error/warning still remains.
> >
> > tree:??
> > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas4Ne1iIw$
> > ? linux-4.19.y
> > head:?? b9f174a70c6f609b6132c3a65883b16d552984b8
> > commit: 8b8ad8a7ac24905937c3975b54c4594b93b66ebb [1539/3265] net:
> > axienet: Wait for PhyRstCmplt after core reset
> > config: microblaze-randconfig-r003-20220704
> > (https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/
> > 20220706/[email protected]/config__;!!IOGos0k!nK_4H
> > G5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZatUAT
> > tDaQ$?)
> > compiler: microblaze-linux-gcc (GCC) 11.3.0
> > reproduce (this is a W=1 build):
> > ??????? wget
> > https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZautG4jkgg$
> > ? -O ~/bin/make.cross
> > ??????? chmod +x ~/bin/make.cross
> > ??????? #
> > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=8b8ad8a7ac24905937c3975b54c4594b93b66ebb__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas8R9M_sA$
> > ?
> > ??????? git remote add linux-stable-rc
> > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas4Ne1iIw$
> > ?
> > ??????? git fetch --no-tags linux-stable-rc linux-4.19.y
> > ??????? git checkout 8b8ad8a7ac24905937c3975b54c4594b93b66ebb
> > ??????? # save the config file
> > ??????? mkdir build_dir && cp config build_dir/.config
> > ??????? COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0
> > make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash
> > drivers/net/ethernet/xilinx/
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <[email protected]>
> >
> > All errors (new ones prefixed by >>):
> >
> > ?? drivers/net/ethernet/xilinx/xilinx_axienet_main.c: In function
> > 'axienet_dma_bd_init':
> > ?? drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9: error:
> > 'ret' undeclared (first use in this function); did you mean 'net'?
> > ???? 283 |???????? ret = read_poll_timeout(axienet_ior, value,
> > ???????? |???????? ^~~
> > ???????? |???????? net
> > ?? drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9: note:
> > each undeclared identifier is reported only once for each function it
> > appears in
> > > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:15: error:
> > > > implicit declaration of function 'read_poll_timeout' [-
> > > > Werror=implicit-function-declaration]
> > ???? 283 |???????? ret = read_poll_timeout(axienet_ior, value,
> > ???????? |?????????????? ^~~~~~~~~~~~~~~~~
> > ?? drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:46: error:
> > 'value' undeclared (first use in this function)
> > ???? 283 |???????? ret = read_poll_timeout(axienet_ior, value,
> > ???????? |????????????????????????????????????????????? ^~~~~
> > ?? cc1: some warnings being treated as errors
> >
>
> This seems like maybe a bad backport of the listed patch to the 4.19
> stable release?
If so, can you provide a fix for this?
thanks,
greg k-h
On Thu, 2022-07-07 at 20:02 +0200, [email protected] wrote:
> On Wed, Jul 06, 2022 at 10:42:48PM +0000, Robert Hancock wrote:
> > On Wed, 2022-07-06 at 18:43 +0800, kernel test robot wrote:
> > > Hi Robert,
> > >
> > > FYI, the error/warning still remains.
> > >
> > > tree:
> > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas4Ne1iIw$
> > > linux-4.19.y
> > > head: b9f174a70c6f609b6132c3a65883b16d552984b8
> > > commit: 8b8ad8a7ac24905937c3975b54c4594b93b66ebb [1539/3265] net:
> > > axienet: Wait for PhyRstCmplt after core reset
> > > config: microblaze-randconfig-r003-20220704
> > > (
> > > https://urldefense.com/v3/__https://download.01.org/0day-ci/archiv
> > > e/
> > > 20220706/[email protected]/config__;!!IOGos0k!n
> > > K_4H
> > > G5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZa
> > > tUAT
> > > tDaQ$ )
> > > compiler: microblaze-linux-gcc (GCC) 11.3.0
> > > reproduce (this is a W=1 build):
> > > wget
> > > https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZautG4jkgg$
> > > -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > #
> > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=8b8ad8a7ac24905937c3975b54c4594b93b66ebb__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas8R9M_sA$
> > >
> > > git remote add linux-stable-rc
> > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas4Ne1iIw$
> > >
> > > git fetch --no-tags linux-stable-rc linux-4.19.y
> > > git checkout 8b8ad8a7ac24905937c3975b54c4594b93b66ebb
> > > # save the config file
> > > mkdir build_dir && cp config build_dir/.config
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0
> > > make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash
> > > drivers/net/ethernet/xilinx/
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <[email protected]>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c: In function
> > > 'axienet_dma_bd_init':
> > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9:
> > > error:
> > > 'ret' undeclared (first use in this function); did you mean
> > > 'net'?
> > > 283 | ret = read_poll_timeout(axienet_ior, value,
> > > | ^~~
> > > | net
> > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9: note:
> > > each undeclared identifier is reported only once for each
> > > function it
> > > appears in
> > > > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:15:
> > > > > error:
> > > > > implicit declaration of function 'read_poll_timeout' [-
> > > > > Werror=implicit-function-declaration]
> > > 283 | ret = read_poll_timeout(axienet_ior, value,
> > > | ^~~~~~~~~~~~~~~~~
> > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:46:
> > > error:
> > > 'value' undeclared (first use in this function)
> > > 283 | ret = read_poll_timeout(axienet_ior, value,
> > > | ^~~~~
> > > cc1: some warnings being treated as errors
> > >
> >
> > This seems like maybe a bad backport of the listed patch to the
> > 4.19
> > stable release?
>
> If so, can you provide a fix for this?
It looks like read_poll_timeout was not in 4.19 so it's not just a
missing include, the code would need to be modified to use a different
API. I don't have a test environment for 4.19 so the most I could do is
compile test it (and in 4.19 this driver could only be enabled on a
limited set of platforms, Microblaze being one, which I assume is why
there weren't more complaints).
Unless someone had a specific reason for requesting this patch
("axienet: Wait for PhyRstCmplt after core reset") be backported to
4.19, it might be easier to just drop it from the 4.19 stable tree -
the problem this is fixing only shows up in certain hardware
configurations, but the driver not compiling is worse..
On Thu, Jul 07, 2022 at 10:24:20PM +0000, Robert Hancock wrote:
> On Thu, 2022-07-07 at 20:02 +0200, [email protected] wrote:
> > On Wed, Jul 06, 2022 at 10:42:48PM +0000, Robert Hancock wrote:
> > > On Wed, 2022-07-06 at 18:43 +0800, kernel test robot wrote:
> > > > Hi Robert,
> > > >
> > > > FYI, the error/warning still remains.
> > > >
> > > > tree:??
> > > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas4Ne1iIw$
> > > > ? linux-4.19.y
> > > > head:?? b9f174a70c6f609b6132c3a65883b16d552984b8
> > > > commit: 8b8ad8a7ac24905937c3975b54c4594b93b66ebb [1539/3265] net:
> > > > axienet: Wait for PhyRstCmplt after core reset
> > > > config: microblaze-randconfig-r003-20220704
> > > > (
> > > > https://urldefense.com/v3/__https://download.01.org/0day-ci/archiv
> > > > e/
> > > > 20220706/[email protected]/config__;!!IOGos0k!n
> > > > K_4H
> > > > G5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZa
> > > > tUAT
> > > > tDaQ$?)
> > > > compiler: microblaze-linux-gcc (GCC) 11.3.0
> > > > reproduce (this is a W=1 build):
> > > > ??????? wget
> > > > https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZautG4jkgg$
> > > > ? -O ~/bin/make.cross
> > > > ??????? chmod +x ~/bin/make.cross
> > > > ??????? #
> > > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=8b8ad8a7ac24905937c3975b54c4594b93b66ebb__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas8R9M_sA$
> > > > ?
> > > > ??????? git remote add linux-stable-rc
> > > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas4Ne1iIw$
> > > > ?
> > > > ??????? git fetch --no-tags linux-stable-rc linux-4.19.y
> > > > ??????? git checkout 8b8ad8a7ac24905937c3975b54c4594b93b66ebb
> > > > ??????? # save the config file
> > > > ??????? mkdir build_dir && cp config build_dir/.config
> > > > ??????? COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0
> > > > make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash
> > > > drivers/net/ethernet/xilinx/
> > > >
> > > > If you fix the issue, kindly add following tag where applicable
> > > > Reported-by: kernel test robot <[email protected]>
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > ?? drivers/net/ethernet/xilinx/xilinx_axienet_main.c: In function
> > > > 'axienet_dma_bd_init':
> > > > ?? drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9:
> > > > error:
> > > > 'ret' undeclared (first use in this function); did you mean
> > > > 'net'?
> > > > ???? 283 |???????? ret = read_poll_timeout(axienet_ior, value,
> > > > ???????? |???????? ^~~
> > > > ???????? |???????? net
> > > > ?? drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9: note:
> > > > each undeclared identifier is reported only once for each
> > > > function it
> > > > appears in
> > > > > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:15:
> > > > > > error:
> > > > > > implicit declaration of function 'read_poll_timeout' [-
> > > > > > Werror=implicit-function-declaration]
> > > > ???? 283 |???????? ret = read_poll_timeout(axienet_ior, value,
> > > > ???????? |?????????????? ^~~~~~~~~~~~~~~~~
> > > > ?? drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:46:
> > > > error:
> > > > 'value' undeclared (first use in this function)
> > > > ???? 283 |???????? ret = read_poll_timeout(axienet_ior, value,
> > > > ???????? |????????????????????????????????????????????? ^~~~~
> > > > ?? cc1: some warnings being treated as errors
> > > >
> > >
> > > This seems like maybe a bad backport of the listed patch to the
> > > 4.19
> > > stable release?
> >
> > If so, can you provide a fix for this?
>
> It looks like read_poll_timeout was not in 4.19 so it's not just a
> missing include, the code would need to be modified to use a different
> API. I don't have a test environment for 4.19 so the most I could do is
> compile test it (and in 4.19 this driver could only be enabled on a
> limited set of platforms, Microblaze being one, which I assume is why
> there weren't more complaints).
>
> Unless someone had a specific reason for requesting this patch
> ("axienet: Wait for PhyRstCmplt after core reset") be backported to
> 4.19, it might be easier to just drop it from the 4.19 stable tree -
> the problem this is fixing only shows up in certain hardware
> configurations, but the driver not compiling is worse..
True, can you send a revert for this?
thanks,
greg k-h