Hi Dmitry,
On 10/20/2017 12:34 AM, Dmitry Osipenko wrote:
> Add binding documentation for the Video Decoder Engine which is found
> on NVIDIA Tegra20/30/114/124/132 SoC's.
>
> Signed-off-by: Dmitry Osipenko <[email protected]>
> ---
> .../devicetree/bindings/media/nvidia,tegra-vde.txt | 55 ++++++++++++++++++++++
> 1 file changed, 55 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt
>
> diff --git a/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt b/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt
> new file mode 100644
> index 000000000000..470237ed6fe5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt
> @@ -0,0 +1,55 @@
> +NVIDIA Tegra Video Decoder Engine
> +
> +Required properties:
> +- compatible : Must contain one of the following values:
> + - "nvidia,tegra20-vde"
> + - "nvidia,tegra30-vde"
> + - "nvidia,tegra114-vde"
> + - "nvidia,tegra124-vde"
> + - "nvidia,tegra132-vde"
> +- reg : Must contain an entry for each entry in reg-names.
> +- reg-names : Must include the following entries:
> + - sxe
> + - bsev
> + - mbe
> + - ppe
> + - mce
> + - tfe
> + - ppb
> + - vdma
> + - frameid
I've already mentioned it in my review of the driver code, but the
version from v3 with a single region is more preferable.
Also it implies that "reg-names" property will be removed.
> +- iram : Must contain phandle to the mmio-sram device node that represents
> + IRAM region used by VDE.
> +- interrupts : Must contain an entry for each entry in interrupt-names.
> +- interrupt-names : Must include the following entries:
> + - sync-token
> + - bsev
> + - sxe
> +- clocks : Must include the following entries:
> + - vde
> +- resets : Must include the following entries:
> + - vde
> +
> +Example:
> +
> +video-codec@6001a000 {
> + compatible = "nvidia,tegra20-vde";
> + reg = <0x6001a000 0x1000 /* Syntax Engine */
> + 0x6001b000 0x1000 /* Video Bitstream Engine */
> + 0x6001c000 0x100 /* Macroblock Engine */
> + 0x6001c200 0x100 /* Post-processing Engine */
> + 0x6001c400 0x100 /* Motion Compensation Engine */
> + 0x6001c600 0x100 /* Transform Engine */
> + 0x6001c800 0x100 /* Pixel prediction block */
> + 0x6001ca00 0x100 /* Video DMA */
> + 0x6001d800 0x300 /* Video frame controls */>;
> + reg-names = "sxe", "bsev", "mbe", "ppe", "mce",
> + "tfe", "ppb", "vdma", "frameid";
> + iram = <&vde_pool>; /* IRAM region */
> + interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, /* Sync token interrupt */
> + <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, /* BSE-V interrupt */
> + <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; /* SXE interrupt */
> + interrupt-names = "sync-token", "bsev", "sxe";
> + clocks = <&tegra_car TEGRA20_CLK_VDE>;
> + resets = <&tegra_car 61>;
> +};
>
--
With best wishes,
Vladimir
From 1582370543849499308@xxx Fri Oct 27 01:02:26 +0000 2017
X-GM-THRID: 1581727893714678178
X-Gmail-Labels: Inbox,Category Forums