2023-09-13 22:26:40

by Aradhya Bhatia

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add full compatible to dss-oldi-io-ctrl node



On 11/09/23 09:25, Andrew Davis wrote:
> This matches the binding for this register region which fixes a couple
> DTS check warnings.
>
> While here trim the leading 0s from the "reg" definition.
>
> Signed-off-by: Andrew Davis <[email protected]>

For both the patches, 1/2 and 2/2,

Reviewed-by: Aradhya Bhatia <[email protected]>

> ---
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index bc460033a37a8..d5f217427893d 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -498,8 +498,8 @@ serdes_mux: mux-controller {
> };
>
> dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {
> - compatible = "syscon";
> - reg = <0x000041e0 0x14>;
> + compatible = "ti,am654-dss-oldi-io-ctrl", "syscon";
> + reg = <0x41e0 0x14>;
> };
>
> ehrpwm_tbclk: clock-controller@4140 {


2023-09-14 12:44:21

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add full compatible to dss-oldi-io-ctrl node

On Wed, 13 Sep 2023, Aradhya Bhatia wrote:

>
>
> On 11/09/23 09:25, Andrew Davis wrote:
> > This matches the binding for this register region which fixes a couple
> > DTS check warnings.
> >
> > While here trim the leading 0s from the "reg" definition.
> >
> > Signed-off-by: Andrew Davis <[email protected]>
>
> For both the patches, 1/2 and 2/2,

If you want to Ack both patches, you have to Ack both patches.

> Reviewed-by: Aradhya Bhatia <[email protected]>
>
> > ---
> > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > index bc460033a37a8..d5f217427893d 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > @@ -498,8 +498,8 @@ serdes_mux: mux-controller {
> > };
> >
> > dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {
> > - compatible = "syscon";
> > - reg = <0x000041e0 0x14>;
> > + compatible = "ti,am654-dss-oldi-io-ctrl", "syscon";
> > + reg = <0x41e0 0x14>;
> > };
> >
> > ehrpwm_tbclk: clock-controller@4140 {

--
Lee Jones [李琼斯]