2020-01-08 07:30:24

by Anson Huang

Subject: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT

Memory address/size depends on board design, so memory node should
be in board DT.

Signed-off-by: Anson Huang <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 -----
2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
index cf044dd..9e54747 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
@@ -16,6 +16,11 @@
stdout-path = &uart2;
};

+ memory@40000000 {
+ device_type = "memory";
+ reg = <0x0 0x40000000 0 0x80000000>;
+ };
+
leds {
compatible = "gpio-leds";
pinctrl-names = "default";
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index a3d179b..1e5e115 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -140,11 +140,6 @@
};
};

- memory@40000000 {
- device_type = "memory";
- reg = <0x0 0x40000000 0 0x80000000>;
- };
-
osc_32k: clock-osc-32k {
compatible = "fixed-clock";
#clock-cells = <0>;
--
2.7.4

2020-01-08 07:30:38

by Anson Huang

Subject: [PATCH 2/2] arm64: dts: imx8mn: Memory node should be in board DT

Memory address/size depends on board design, so memory node should
be in board DT.

Signed-off-by: Anson Huang <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 5 +++++
arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 -----
2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
index 7a92952..0d2ec4a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
@@ -23,6 +23,11 @@
};
};

+ memory@40000000 {
+ device_type = "memory";
+ reg = <0x0 0x40000000 0 0x80000000>;
+ };
+
reg_usdhc2_vmmc: regulator-usdhc2 {
compatible = "regulator-fixed";
pinctrl-names = "default";
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index cce65b9..4014029 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -139,11 +139,6 @@
};
};

- memory@40000000 {
- device_type = "memory";
- reg = <0x0 0x40000000 0 0x80000000>;
- };
-
osc_32k: clock-osc-32k {
compatible = "fixed-clock";
#clock-cells = <0>;
--
2.7.4

2020-01-08 10:23:01

by Daniel Baluta

Subject: Re: [PATCH 2/2] arm64: dts: imx8mn: Memory node should be in board DT

On Wed, 2020-01-08 at 15:25 +0800, Anson Huang wrote:
> Memory address/size depends on board design, so memory node should
> be in board DT.
>
> Signed-off-by: Anson Huang <[email protected]>

Reviewed-by: Daniel Baluta <[email protected]>


> ---
> arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 5 +++++
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 -----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> index 7a92952..0d2ec4a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> @@ -23,6 +23,11 @@
> };
> };
>
> + memory@40000000 {
> + device_type = "memory";
> + reg = <0x0 0x40000000 0 0x80000000>;
> + };
> +
> reg_usdhc2_vmmc: regulator-usdhc2 {
> compatible = "regulator-fixed";
> pinctrl-names = "default";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index cce65b9..4014029 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -139,11 +139,6 @@
> };
> };
>
> - memory@40000000 {
> - device_type = "memory";
> - reg = <0x0 0x40000000 0 0x80000000>;
> - };
> -
> osc_32k: clock-osc-32k {
> compatible = "fixed-clock";
> #clock-cells = <0>;

2020-01-08 10:27:53

by Daniel Baluta

Subject: Re: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT

On Wed, 2020-01-08 at 15:25 +0800, Anson Huang wrote:
> Memory address/size depends on board design, so memory node should
> be in board DT.
>
> Signed-off-by: Anson Huang <[email protected]>

Reviewed-by: Daniel Baluta <[email protected]>

Care to add a cover letter for your next patch series? :).

Just use --cover-letter argument for git format-patch.

Thus, we can keep revision history centralized and can just one
Reviewed-by/Tested-by tag :).

> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 -----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index cf044dd..9e54747 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -16,6 +16,11 @@
> stdout-path = &uart2;
> };
>
> + memory@40000000 {
> + device_type = "memory";
> + reg = <0x0 0x40000000 0 0x80000000>;
> + };
> +
> leds {
> compatible = "gpio-leds";
> pinctrl-names = "default";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index a3d179b..1e5e115 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -140,11 +140,6 @@
> };
> };
>
> - memory@40000000 {
> - device_type = "memory";
> - reg = <0x0 0x40000000 0 0x80000000>;
> - };
> -
> osc_32k: clock-osc-32k {
> compatible = "fixed-clock";
> #clock-cells = <0>;

2020-01-08 10:48:34

by Peng Fan

Subject: RE: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT

> Cc: dl-linux-imx <[email protected]>
> Subject: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board
> DT
>
> Memory address/size depends on board design, so memory node should be in
> board DT.

Not sure it really matters, bootloader will update/create memory node of device
tree.

Regards,
Peng.

>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 -----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index cf044dd..9e54747 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -16,6 +16,11 @@
> stdout-path = &uart2;
> };
>
> + memory@40000000 {
> + device_type = "memory";
> + reg = <0x0 0x40000000 0 0x80000000>;
> + };
> +
> leds {
> compatible = "gpio-leds";
> pinctrl-names = "default";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index a3d179b..1e5e115 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -140,11 +140,6 @@
> };
> };
>
> - memory@40000000 {
> - device_type = "memory";
> - reg = <0x0 0x40000000 0 0x80000000>;
> - };
> -
> osc_32k: clock-osc-32k {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> --
> 2.7.4

2020-01-09 12:35:36

by Shawn Guo

Subject: Re: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT

On Wed, Jan 08, 2020 at 03:25:28PM +0800, Anson Huang wrote:
> Memory address/size depends on board design, so memory node should
> be in board DT.
>
> Signed-off-by: Anson Huang <[email protected]>

Applied both, thanks.