Andrew, another one for drivers-add-lcd-support saga. Thanks you.
---
- Fix Randy Dunlap's points:
? Adds CONFIG_FB dependency to CONFIG_CFAG12864B
? Spelling fix and improved help.
Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
drivers-add-lcd-support-update9.patch
Signed-off-by: Miguel Ojeda Sandonis <[email protected]>
---
diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index 8d41f72..a6fc2b7 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -65,6 +65,7 @@ config KS0108_DELAY
config CFAG12864B
tristate "CFAG12864B LCD"
depends on X86
+ depends on FB
depends on KS0108
default n
---help---
@@ -74,6 +75,8 @@ config CFAG12864B
For help about how to wire your LCD to the parallel port,
check Documentation/auxdisplay/cfag12864b
+ Depends on the x86 arch and the framebuffer support.
+
The LCD framebuffer driver can be attached to a console.
It will work fine. However, you can't attach it to the fbdev driver
of the xorg server.
@@ -84,7 +87,7 @@ config CFAG12864B
If unsure, say N.
config CFAG12864B_RATE
- int "Refresh rate (hertzs)"
+ int "Refresh rate (hertz)"
depends on CFAG12864B
default "20"
---help---
@@ -104,4 +107,3 @@ config CFAG12864B_RATE
If you compile this as a module, you can still override this
value using the module parameters.
endmenu
-
On Wed, 20 Dec 2006 15:10:00 +0100
Miguel Ojeda Sandonis <[email protected]> wrote:
> Andrew, another one for drivers-add-lcd-support saga. Thanks you.
This patch appears to be against some private tree of yours, not against -mm.
Which tells me that it hasn't been tested against the patches in -mm and,
more importantly, that probably nobody is testing the patches which are
in -mm.
I'd prefer that you do so, please - there's always a possibility that the
patches got mangled in flight, or that some other pending change in -mm
means that the patches work in your tree, but won't work when I merge them
up.
Thanks.
On Wed, 20 Dec 2006 15:10:00 +0100
Miguel Ojeda Sandonis <[email protected]> wrote:
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -65,6 +65,7 @@ config KS0108_DELAY
> config CFAG12864B
> tristate "CFAG12864B LCD"
> depends on X86
> + depends on FB
> depends on KS0108
> default n
> ---help---
> @@ -74,6 +75,8 @@ config CFAG12864B
> For help about how to wire your LCD to the parallel port,
> check Documentation/auxdisplay/cfag12864b
>
> + Depends on the x86 arch and the framebuffer support.
heh, that was clever.
scripts/kconfig/conf -m arch/i386/Kconfig
drivers/auxdisplay/Kconfig:81:warning: multi-line strings not supported
drivers/auxdisplay/Kconfig:78: unknown option "Depends"
drivers/auxdisplay/Kconfig:80: unknown option "The"
drivers/auxdisplay/Kconfig:81: unknown option "It"
drivers/auxdisplay/Kconfig:82: unknown option "of"
drivers/auxdisplay/Kconfig:84: unknown option "To"
drivers/auxdisplay/Kconfig:85: unknown option "the"
drivers/auxdisplay/Kconfig:87: unknown option "If"
make[1]: *** [allmodconfig] Error 1
you broke Roman's parser.
Oh, your patch used spaces where tabs should have been. Please don't do
that.
On 12/21/06, Andrew Morton <[email protected]> wrote:
> On Wed, 20 Dec 2006 15:10:00 +0100
> Miguel Ojeda Sandonis <[email protected]> wrote:
>
> > Andrew, another one for drivers-add-lcd-support saga. Thanks you.
>
> This patch appears to be against some private tree of yours, not against -mm.
>
> Which tells me that it hasn't been tested against the patches in -mm and,
> more importantly, that probably nobody is testing the patches which are
> in -mm.
>
> I'd prefer that you do so, please - there's always a possibility that the
> patches got mangled in flight, or that some other pending change in -mm
> means that the patches work in your tree, but won't work when I merge them
> up.
>
> Thanks.
>
On 12/21/06, Andrew Morton <[email protected]> wrote:
> On Wed, 20 Dec 2006 15:10:00 +0100
> Miguel Ojeda Sandonis <[email protected]> wrote:
>
> > --- a/drivers/auxdisplay/Kconfig
> > +++ b/drivers/auxdisplay/Kconfig
> > @@ -65,6 +65,7 @@ config KS0108_DELAY
> > config CFAG12864B
> > tristate "CFAG12864B LCD"
> > depends on X86
> > + depends on FB
> > depends on KS0108
> > default n
> > ---help---
> > @@ -74,6 +75,8 @@ config CFAG12864B
> > For help about how to wire your LCD to the parallel port,
> > check Documentation/auxdisplay/cfag12864b
> >
> > + Depends on the x86 arch and the framebuffer support.
>
> heh, that was clever.
>
> scripts/kconfig/conf -m arch/i386/Kconfig
> drivers/auxdisplay/Kconfig:81:warning: multi-line strings not supported
> drivers/auxdisplay/Kconfig:78: unknown option "Depends"
> drivers/auxdisplay/Kconfig:80: unknown option "The"
> drivers/auxdisplay/Kconfig:81: unknown option "It"
> drivers/auxdisplay/Kconfig:82: unknown option "of"
> drivers/auxdisplay/Kconfig:84: unknown option "To"
> drivers/auxdisplay/Kconfig:85: unknown option "the"
> drivers/auxdisplay/Kconfig:87: unknown option "If"
> make[1]: *** [allmodconfig] Error 1
>
> you broke Roman's parser.
>
>
> Oh, your patch used spaces where tabs should have been. Please don't do
> that.
>
Hum, I have checked the patch again and it applies cleanly against
2.6.20-rc1-mm1. Moreover, it works for me and I see I didn't make any
mistake.
...?
Oh. Right. All tabs were converted to spaces when copying it from the
console to the mail client... Sorry about that.
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm