2007-08-13 07:26:32

by Joe Perches

[permalink] [raw]
Subject: [PATCH] [120/2many] MAINTAINERS - CFAG12864BFB LCD FRAMEBUFFER DRIVER

Add file pattern to MAINTAINER entry

Signed-off-by: Joe Perches <[email protected]>

diff --git a/MAINTAINERS b/MAINTAINERS
index fdedf32..0f5a92f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1169,6 +1169,8 @@ M: [email protected]
L: [email protected]
W: http://auxdisplay.googlepages.com/
S: Maintained
+F: drivers/auxdisplay/cfag12864bfb.c
+F: include/linux/cfag12864b.h

CFG80211 and NL80211
P: Johannes Berg


2007-08-16 09:16:38

by Miguel Ojeda

[permalink] [raw]
Subject: Re: [PATCH] [120/2many] MAINTAINERS - CFAG12864BFB LCD FRAMEBUFFER DRIVER

On 8/13/07, [email protected] <[email protected]> wrote:
> Add file pattern to MAINTAINER entry
>
> Signed-off-by: Joe Perches <[email protected]>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fdedf32..0f5a92f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1169,6 +1169,8 @@ M: [email protected]
> L: [email protected]
> W: http://auxdisplay.googlepages.com/
> S: Maintained
> +F: drivers/auxdisplay/cfag12864bfb.c
> +F: include/linux/cfag12864b.h
>
> CFG80211 and NL80211
> P: Johannes Berg
>

I think you could add also:

+F: Documentation/auxdisplay/cfag12864bfb

as you did at the ks0108 driver entry.

Thank you for the patch.

--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm

2007-08-16 13:55:32

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] [120/2many] MAINTAINERS - CFAG12864BFB LCD FRAMEBUFFER DRIVER

On Thu, 2007-08-16 at 11:16 +0200, Miguel Ojeda wrote:
> I think you could add also:
> +F: Documentation/auxdisplay/cfag12864bfb

This is what I have now:

CFAG12864BFB LCD FRAMEBUFFER DRIVER
P: Miguel Ojeda Sandonis
M: [email protected]
L: [email protected]
W: http://auxdisplay.googlepages.com/
S: Maintained
F: Documentation/auxdisplay/cfag12864bfb
F: drivers/auxdisplay/cfag12864bfb.c
F: include/linux/cfag12864b.h

Joe

2007-08-17 04:27:19

by Miguel Ojeda

[permalink] [raw]
Subject: Re: [PATCH] [120/2many] MAINTAINERS - CFAG12864BFB LCD FRAMEBUFFER DRIVER

On 8/16/07, Joe Perches <[email protected]> wrote:
> On Thu, 2007-08-16 at 11:16 +0200, Miguel Ojeda wrote:
> > I think you could add also:
> > +F: Documentation/auxdisplay/cfag12864bfb
>
> This is what I have now:
>
> CFAG12864BFB LCD FRAMEBUFFER DRIVER
> P: Miguel Ojeda Sandonis
> M: [email protected]
> L: [email protected]
> W: http://auxdisplay.googlepages.com/
> S: Maintained
> F: Documentation/auxdisplay/cfag12864bfb
> F: drivers/auxdisplay/cfag12864bfb.c
> F: include/linux/cfag12864b.h
>
> Joe
>
>

Fine, thank you for the patch!

Signed-off-by: Miguel Ojeda <[email protected]>

--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm

2007-08-17 04:37:45

by Miguel Ojeda

[permalink] [raw]
Subject: Re: [PATCH] [120/2many] MAINTAINERS - CFAG12864BFB LCD FRAMEBUFFER DRIVER

On 8/16/07, Joe Perches <[email protected]> wrote:
> On Thu, 2007-08-16 at 11:16 +0200, Miguel Ojeda wrote:
> > I think you could add also:
> > +F: Documentation/auxdisplay/cfag12864bfb
>
> This is what I have now:
>
> CFAG12864BFB LCD FRAMEBUFFER DRIVER
> P: Miguel Ojeda Sandonis
> M: [email protected]
> L: [email protected]
> W: http://auxdisplay.googlepages.com/
> S: Maintained
> F: Documentation/auxdisplay/cfag12864bfb
> F: drivers/auxdisplay/cfag12864bfb.c
> F: include/linux/cfag12864b.h
>
> Joe
>
>

Oh, I got confused by the different emails:

Documentation/auxdisplay/cfag12864bfb

does not exist. I meant

Documentation/auxdisplay/cfag12864b

Also, in this patch:

[PATCH] [119/2many] MAINTAINERS - CFAG12864B LCD DRIVER

You could add the same line:

Documentation/auxdisplay/cfag12864b

As it is related to the same stuff: cfag12864b is the driver that
makes the LCD work along with ks0108; and cfag12864bfb is a
framebuffer to work with the LCD from userspace. I named it
"cfag12864b" because that is the name of the LCD, so people will not
get confused with the "fb".

As Documentation/auxdisplay/cfag12864b describes both at the same
time, it is OK to add them in both entries.

Sorry for the mistake.

--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm

2007-08-17 04:55:33

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] [120/2many] MAINTAINERS - CFAG12864BFB LCD FRAMEBUFFER DRIVER

On Fri, 2007-08-17 at 06:37 +0200, Miguel Ojeda wrote:
> On 8/16/07, Joe Perches <[email protected]> wrote:
> > On Thu, 2007-08-16 at 11:16 +0200, Miguel Ojeda wrote:
> > > I think you could add also:
> > > +F: Documentation/auxdisplay/cfag12864bfb
> does not exist. I meant
> Documentation/auxdisplay/cfag12864b
> As Documentation/auxdisplay/cfag12864b describes both at the same
> time, it is OK to add them in both entries.
> Sorry for the mistake.

No worries. We all make a bunch of 'em.

This is what I have now:

CFAG12864B LCD DRIVER
P: Miguel Ojeda Sandonis
M: [email protected]
L: [email protected]
W: http://auxdisplay.googlepages.com/
S: Maintained
F: Documentation/auxdisplay/cfag12864b
F: drivers/auxdisplay/cfag12864b.c
F: include/linux/cfag12864b.h

CFAG12864BFB LCD FRAMEBUFFER DRIVER
P: Miguel Ojeda Sandonis
M: [email protected]
L: [email protected]
W: http://auxdisplay.googlepages.com/
S: Maintained
F: Documentation/auxdisplay/cfag12864b
F: drivers/auxdisplay/cfag12864bfb.c
F: include/linux/cfag12864b.h

cheers, Joe

2007-08-17 05:21:19

by Miguel Ojeda

[permalink] [raw]
Subject: Re: [PATCH] [120/2many] MAINTAINERS - CFAG12864BFB LCD FRAMEBUFFER DRIVER

On 8/17/07, Joe Perches <[email protected]> wrote:
> On Fri, 2007-08-17 at 06:37 +0200, Miguel Ojeda wrote:
> > On 8/16/07, Joe Perches <[email protected]> wrote:
> > > On Thu, 2007-08-16 at 11:16 +0200, Miguel Ojeda wrote:
> > > > I think you could add also:
> > > > +F: Documentation/auxdisplay/cfag12864bfb
> > does not exist. I meant
> > Documentation/auxdisplay/cfag12864b
> > As Documentation/auxdisplay/cfag12864b describes both at the same
> > time, it is OK to add them in both entries.
> > Sorry for the mistake.
>
> No worries. We all make a bunch of 'em.
>
> This is what I have now:
>
> CFAG12864B LCD DRIVER
> P: Miguel Ojeda Sandonis
> M: [email protected]
> L: [email protected]
> W: http://auxdisplay.googlepages.com/
> S: Maintained
> F: Documentation/auxdisplay/cfag12864b
> F: drivers/auxdisplay/cfag12864b.c
> F: include/linux/cfag12864b.h
>
> CFAG12864BFB LCD FRAMEBUFFER DRIVER
> P: Miguel Ojeda Sandonis
> M: [email protected]
> L: [email protected]
> W: http://auxdisplay.googlepages.com/
> S: Maintained
> F: Documentation/auxdisplay/cfag12864b
> F: drivers/auxdisplay/cfag12864bfb.c
> F: include/linux/cfag12864b.h
>
> cheers, Joe
>
>

Fine!

Btw, you did me to look at the Documentation to check the correct name
of the "cfag12864b" file, and now, looking at the code, I have
discovered a one-line bug... So the mistake will solve two things at
the same thing! I'm creating the patch now.

Signed-off-by: Miguel Ojeda <[email protected]>

--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm