2021-06-19 08:58:05

by Jiabing Wan

Subject: [PATCH] um: remove unneeded semicolon in um_arch.c

Fix following coccicheck warning:
./arch/um/kernel/um_arch.c:284:34-35: Unneeded semicolon

Signed-off-by: Wan Jiabing <[email protected]>
---
arch/um/kernel/um_arch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
index f9f1463f0521..a149a5e9a16a 100644
--- a/arch/um/kernel/um_arch.c
+++ b/arch/um/kernel/um_arch.c
@@ -281,7 +281,7 @@ static void parse_host_cpu_flags(char *line)
int i;
for (i = 0; i < 32*NCAPINTS; i++) {
if ((x86_cap_flags[i] != NULL) && strstr(line, x86_cap_flags[i]))
- set_cpu_cap(&boot_cpu_data, i);;
+ set_cpu_cap(&boot_cpu_data, i);
}
}
static void parse_cache_line(char *line)
--
2.20.1

2021-06-19 09:54:31

by Anton Ivanov

Subject: Re: [PATCH] um: remove unneeded semicolon in um_arch.c

On 19/06/2021 03:02, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./arch/um/kernel/um_arch.c:284:34-35: Unneeded semicolon
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> arch/um/kernel/um_arch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
> index f9f1463f0521..a149a5e9a16a 100644
> --- a/arch/um/kernel/um_arch.c
> +++ b/arch/um/kernel/um_arch.c
> @@ -281,7 +281,7 @@ static void parse_host_cpu_flags(char *line)
> int i;
> for (i = 0; i < 32*NCAPINTS; i++) {
> if ((x86_cap_flags[i] != NULL) && strstr(line, x86_cap_flags[i]))
> - set_cpu_cap(&boot_cpu_data, i);;
> + set_cpu_cap(&boot_cpu_data, i);
> }
> }
> static void parse_cache_line(char *line)
>

Thanks.

I do not think the patch which introduces this ([v7,1/3] um: Add support
for host CPU flags and alignment) has been merged yet. I do not see it
in the tree as of this morning.

I can see that it is already marked as done in patchwork so it is on its
way.

Richard, what do you want me to do - reissue a fixed one or we should
accept the fix once the original is merged?

--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/

2021-06-19 10:04:03

by Richard Weinberger

Subject: Re: [PATCH] um: remove unneeded semicolon in um_arch.c

Anton,

----- Ursprüngliche Mail -----
> Thanks.
>
> I do not think the patch which introduces this ([v7,1/3] um: Add support
> for host CPU flags and alignment) has been merged yet. I do not see it
> in the tree as of this morning.
>
> I can see that it is already marked as done in patchwork so it is on its
> way.
>
> Richard, what do you want me to do - reissue a fixed one or we should
> accept the fix once the original is merged?

I have just applied the fix to UML's next tree. :-)

Thanks,
//richard