2022-11-18 08:34:34

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH v2] dt-bindings: interconnect: qcom-bwmon: document SM8550 compatibles

Document the compatibles used to describe the Bandwidth Monitors
present on the SM8550 platform.

A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
bandwidth monitoring.

This is described by adding "llcc" and "cpu" into the compatible
strings to differentiate the BWMON IPs.

Signed-off-by: Neil Armstrong <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
To: Krzysztof Kozlowski <[email protected]>
To: Andy Gross <[email protected]>
To: Bjorn Andersson <[email protected]>
To: Konrad Dybcio <[email protected]>
To: Georgi Djakov <[email protected]>
To: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Changes in v2:
- Reworded commit message
- Added Reviewed-by from Krzysztof
- Link to v1: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v1-0-b6dd08927f35@linaro.org
---
.../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
index be29e0b80995..00b635662697 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
@@ -26,8 +26,13 @@ properties:
- enum:
- qcom,sc7280-cpu-bwmon
- qcom,sdm845-bwmon
+ - qcom,sm8550-cpu-bwmon
- const: qcom,msm8998-bwmon
- const: qcom,msm8998-bwmon # BWMON v4
+ - items:
+ - enum:
+ - qcom,sm8550-llcc-bwmon
+ - const: qcom,sc7280-llcc-bwmon
- const: qcom,sc7280-llcc-bwmon # BWMON v5
- const: qcom,sdm845-llcc-bwmon # BWMON v5


---
base-commit: 3aec1f3082a7f388d04a1fa1a351aa25fd6335f0
change-id: 20221114-narmstrong-sm8550-upstream-bwmon-a7c6227fab6d

Best regards,
--
Neil Armstrong <[email protected]>


2023-01-09 10:42:31

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: interconnect: qcom-bwmon: document SM8550 compatibles

Hi Georgi,

On 18/11/2022 09:29, Neil Armstrong wrote:
> Document the compatibles used to describe the Bandwidth Monitors
> present on the SM8550 platform.
>
> A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
> bandwidth monitoring.
>
> This is described by adding "llcc" and "cpu" into the compatible
> strings to differentiate the BWMON IPs.
>
> Signed-off-by: Neil Armstrong <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> ---
> To: Krzysztof Kozlowski <[email protected]>
> To: Andy Gross <[email protected]>
> To: Bjorn Andersson <[email protected]>
> To: Konrad Dybcio <[email protected]>
> To: Georgi Djakov <[email protected]>
> To: Rob Herring <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> Changes in v2:
> - Reworded commit message
> - Added Reviewed-by from Krzysztof
> - Link to v1: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v1-0-b6dd08927f35@linaro.org
> ---
> .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>

<snip>


Gentle ping,

Thanks,
Neil

2023-01-09 11:39:44

by Georgi Djakov

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: interconnect: qcom-bwmon: document SM8550 compatibles

Hi Neil,

On 9.01.23 12:09, Neil Armstrong wrote:
> Hi Georgi,
>
> On 18/11/2022 09:29, Neil Armstrong wrote:
>> Document the compatibles used to describe the Bandwidth Monitors
>> present on the SM8550 platform.
>>
>> A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
>> bandwidth monitoring.
>>
>> This is described by adding "llcc" and "cpu" into the compatible
>> strings to differentiate the BWMON IPs.
>>
>> Signed-off-by: Neil Armstrong <[email protected]>
>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> To: Krzysztof Kozlowski <[email protected]>
>> To: Andy Gross <[email protected]>
>> To: Bjorn Andersson <[email protected]>
>> To: Konrad Dybcio <[email protected]>
>> To: Georgi Djakov <[email protected]>
>> To: Rob Herring <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> ---
>> Changes in v2:
>> - Reworded commit message
>> - Added Reviewed-by from Krzysztof
>> - Link to v1:
>> https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v1-0-b6dd08927f35@linaro.org
>> ---
>>   .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml         | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>
> <snip>
>
>
> Gentle ping,

Thanks for the patch! Could you please rebase and resend?

BR,
Georgi

2023-01-09 12:20:31

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: interconnect: qcom-bwmon: document SM8550 compatibles

On 09/01/2023 12:18, Georgi Djakov wrote:
> Hi Neil,
>
> On 9.01.23 12:09, Neil Armstrong wrote:
>> Hi Georgi,
>>
>> On 18/11/2022 09:29, Neil Armstrong wrote:
>>> Document the compatibles used to describe the Bandwidth Monitors
>>> present on the SM8550 platform.
>>>
>>> A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
>>> bandwidth monitoring.
>>>
>>> This is described by adding "llcc" and "cpu" into the compatible
>>> strings to differentiate the BWMON IPs.
>>>
>>> Signed-off-by: Neil Armstrong <[email protected]>
>>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>>> ---
>>> To: Krzysztof Kozlowski <[email protected]>
>>> To: Andy Gross <[email protected]>
>>> To: Bjorn Andersson <[email protected]>
>>> To: Konrad Dybcio <[email protected]>
>>> To: Georgi Djakov <[email protected]>
>>> To: Rob Herring <[email protected]>
>>> Cc: [email protected]
>>> Cc: [email protected]
>>> Cc: [email protected]
>>> Cc: [email protected]
>>> ---
>>> Changes in v2:
>>> - Reworded commit message
>>> - Added Reviewed-by from Krzysztof
>>> - Link to v1: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v1-0-b6dd08927f35@linaro.org
>>> ---
>>>   .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml         | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>
>> <snip>
>>
>>
>> Gentle ping,
>
> Thanks for the patch! Could you please rebase and resend?

Sure

Thanks,
Neil

>
> BR,
> Georgi