2024-04-13 16:21:41

by Christophe JAILLET

Subject: [PATCH] clk: renesas: r8a7740: Remove an unused field in struct div4_clk

In "struct div4_clk", the 'flags' field is unused.

Remove it and update the 'div4_clks' array accordingly.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.

Apparently, it has never been used. It is not a left-over from a
refactoring. I don't if it is supposed to be used somewhere in the driver.

Should it help the review, renesas/clk-r8a73a4.c has a very similar
construction and also a struct div4_clk without this 'flags' field.
---
drivers/clk/renesas/clk-r8a7740.c | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/drivers/clk/renesas/clk-r8a7740.c b/drivers/clk/renesas/clk-r8a7740.c
index 3ee3f57e4e9a..325394b6e55e 100644
--- a/drivers/clk/renesas/clk-r8a7740.c
+++ b/drivers/clk/renesas/clk-r8a7740.c
@@ -32,22 +32,21 @@ struct div4_clk {
const char *name;
unsigned int reg;
unsigned int shift;
- int flags;
};

static struct div4_clk div4_clks[] = {
- { "i", CPG_FRQCRA, 20, CLK_ENABLE_ON_INIT },
- { "zg", CPG_FRQCRA, 16, CLK_ENABLE_ON_INIT },
- { "b", CPG_FRQCRA, 8, CLK_ENABLE_ON_INIT },
- { "m1", CPG_FRQCRA, 4, CLK_ENABLE_ON_INIT },
- { "hp", CPG_FRQCRB, 4, 0 },
- { "hpp", CPG_FRQCRC, 20, 0 },
- { "usbp", CPG_FRQCRC, 16, 0 },
- { "s", CPG_FRQCRC, 12, 0 },
- { "zb", CPG_FRQCRC, 8, 0 },
- { "m3", CPG_FRQCRC, 4, 0 },
- { "cp", CPG_FRQCRC, 0, 0 },
- { NULL, 0, 0, 0 },
+ { "i", CPG_FRQCRA, 20 },
+ { "zg", CPG_FRQCRA, 16 },
+ { "b", CPG_FRQCRA, 8 },
+ { "m1", CPG_FRQCRA, 4 },
+ { "hp", CPG_FRQCRB, 4 },
+ { "hpp", CPG_FRQCRC, 20 },
+ { "usbp", CPG_FRQCRC, 16 },
+ { "s", CPG_FRQCRC, 12 },
+ { "zb", CPG_FRQCRC, 8 },
+ { "m3", CPG_FRQCRC, 4 },
+ { "cp", CPG_FRQCRC, 0 },
+ { NULL, 0, 0 },
};

static const struct clk_div_table div4_div_table[] = {
--
2.44.0

2024-04-24 13:08:42

by Geert Uytterhoeven

Subject: Re: [PATCH] clk: renesas: r8a7740: Remove an unused field in struct div4_clk

On Sat, Apr 13, 2024 at 6:19 PM Christophe JAILLET
<[email protected]> wrote:
> In "struct div4_clk", the 'flags' field is unused.
>
> Remove it and update the 'div4_clks' array accordingly.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
Tested-by: Geert Uytterhoeven <[email protected]>

i.e. will queue in renesas-clk for v6.10.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds