2024-01-09 00:47:45

by Yang Li

Subject: [PATCH -next] cxl: Remove duplicated include in cdat.c

The header files core.h is included twice in cdat.c,
so one inclusion can be removed.

Signed-off-by: Yang Li <[email protected]>
---
drivers/cxl/core/cdat.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
index f5e649407b8b..6fe11546889f 100644
--- a/drivers/cxl/core/cdat.c
+++ b/drivers/cxl/core/cdat.c
@@ -9,7 +9,6 @@
#include "cxlmem.h"
#include "core.h"
#include "cxl.h"
-#include "core.h"

struct dsmas_entry {
struct range dpa_range;
--
2.20.1.7.g153144c

2024-01-09 15:18:34

by Jonathan Cameron

Subject: Re: [PATCH -next] cxl: Remove duplicated include in cdat.c

On Tue, 9 Jan 2024 08:47:28 +0800
Yang Li <[email protected]> wrote:

> The header files core.h is included twice in cdat.c,
> so one inclusion can be removed.
>
> Signed-off-by: Yang Li <[email protected]>
Obviously correct :)

Reviewed-by: Jonathan Cameron <[email protected]>

> ---
> drivers/cxl/core/cdat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index f5e649407b8b..6fe11546889f 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -9,7 +9,6 @@
> #include "cxlmem.h"
> #include "core.h"
> #include "cxl.h"
> -#include "core.h"
>
> struct dsmas_entry {
> struct range dpa_range;

2024-01-11 23:55:23

by Dave Jiang

Subject: Re: [PATCH -next] cxl: Remove duplicated include in cdat.c

On 1/8/24 17:47, Yang Li wrote:
> The header files core.h is included twice in cdat.c,
> so one inclusion can be removed.
>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Dave Jiang <[email protected]>
> ---
> drivers/cxl/core/cdat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index f5e649407b8b..6fe11546889f 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -9,7 +9,6 @@
> #include "cxlmem.h"
> #include "core.h"
> #include "cxl.h"
> -#include "core.h"
>
> struct dsmas_entry {
> struct range dpa_range;

2024-01-12 00:45:37

by Dan Williams

Subject: RE: [PATCH -next] cxl: Remove duplicated include in cdat.c

Yang Li wrote:
> The header files core.h is included twice in cdat.c,
> so one inclusion can be removed.
>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/cxl/core/cdat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index f5e649407b8b..6fe11546889f 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -9,7 +9,6 @@
> #include "cxlmem.h"
> #include "core.h"
> #include "cxl.h"
> -#include "core.h"

I believe that was due to a bad merge by me. That's fixed up now with a
better merge commit.

Thanks for spotting this though!