2024-05-01 18:40:41

by Ira Weiny

Subject: [PATCH] cxl/cper: Fix non-ACPI-APEI-GHES build

If ACPI_APEI_GHES is not configured the [un]register work functions are
not properly declared.

Fix copy paste error.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Ira Weiny <[email protected]>
---
include/linux/cxl-event.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
index a0067c49e2ca..13090857c066 100644
--- a/include/linux/cxl-event.h
+++ b/include/linux/cxl-event.h
@@ -152,12 +152,12 @@ int cxl_cper_register_work(struct work_struct *work);
int cxl_cper_unregister_work(struct work_struct *work);
int cxl_cper_kfifo_get(struct cxl_cper_work_data *wd);
#else
-static inline int cxl_cper_register_work(struct work_struct *work);
+static inline int cxl_cper_register_work(struct work_struct *work)
{
return 0;
}

-static inline int cxl_cper_unregister_work(struct work_struct *work);
+static inline int cxl_cper_unregister_work(struct work_struct *work)
{
return 0;
}

---
base-commit: c19ac30eda3a1d14d4883de0ea214b6c5c96a9b4
change-id: 20240501-cper-fix-0day-c03ad861bbc3

Best regards,
--
Ira Weiny <[email protected]>

2024-05-01 18:51:47

by Dan Williams

Subject: Re: [PATCH] cxl/cper: Fix non-ACPI-APEI-GHES build

Ira Weiny wrote:
> If ACPI_APEI_GHES is not configured the [un]register work functions are
> not properly declared.
>
> Fix copy paste error.

Copy paste? I would just say:

0day notices that the cxl_cper_register_work() declaration in the
CONFIG_ACPI_APEI_GHES=n is broken, fix it to be typical nop stub.

>
> Reported-by: kernel test robot <[email protected]>

Checkpatch asks for Closes: tags these days:

Closes: http://lore.kernel.org/r/[email protected]

With that,

Reviewed-by: Dan Williams <[email protected]>