http://bugzilla.kernel.org/show_bug.cgi?id=6537
Summary: #ifdef CONFIG_PM causes MPT to not compile
Kernel Version: 2.6.17-rc4
Status: NEW
Severity: blocking
Owner: [email protected]
Submitter: [email protected]
Most recent kernel where this bug did not occur: 2.6.17-rc3
Distribution: slack
Hardware Environment: i386
Software Environment: gcc 3.3
Problem Description: /drivers/message/fusion/mpt* using #ifdef CONFIG_PM
are not
exporting the mpt_suspend mpt_resume. I do not know why we would want to
exercise power management on high-performance scsi controllers in the first
place. LSI controllers are server devices.
Steps to reproduce: compile the kernel. causes a kernel compilation failure.
Steps to fix:
comment out the #ifdef CONFIG_pm and corresponding #endif to disable this
compilation flag. recompile and the world is happy.
On Fri, May 12, 2006 at 07:58:54AM -0700, Martin J. Bligh wrote:
> Problem Description: /drivers/message/fusion/mpt* using #ifdef CONFIG_PM
> are not exporting the mpt_suspend mpt_resume.
> Steps to reproduce: compile the kernel. causes a kernel compilation failure.
>
> Steps to fix:
> comment out the #ifdef CONFIG_pm and corresponding #endif to disable this
> compilation flag. recompile and the world is happy.
This patch fixes your anonymous compilation problems?
[PATCH] mptspi: fix compilation with CONFIG_PM=n
Signed-off-by: Alexey Dobriyan <[email protected]>
--- a/drivers/message/fusion/mptspi.c
+++ b/drivers/message/fusion/mptspi.c
@@ -831,6 +831,7 @@ mptspi_ioc_reset(MPT_ADAPTER *ioc, int r
return rc;
}
+#ifdef CONFIG_PM
/*
* spi module resume handler
*/
@@ -846,6 +847,7 @@ mptspi_resume(struct pci_dev *pdev)
return rc;
}
+#endif
/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
On Friday, May 12, 2006 10:46 AM, Alexey Dobriyan wrote:
> This patch fixes your anonymous compilation problems?
>
> [PATCH] mptspi: fix compilation with CONFIG_PM=n
>
> Signed-off-by: Alexey Dobriyan <[email protected]>
>
> --- a/drivers/message/fusion/mptspi.c
> +++ b/drivers/message/fusion/mptspi.c
> @@ -831,6 +831,7 @@ mptspi_ioc_reset(MPT_ADAPTER *ioc, int r
> return rc;
> }
>
> +#ifdef CONFIG_PM
> /*
> * spi module resume handler
> */
> @@ -846,6 +847,7 @@ mptspi_resume(struct pci_dev *pdev)
>
> return rc;
> }
> +#endif
>
ACK
Alex, thanks. Can you post this patch over on the linux-scsi@ list, and
copy James Bottomley?
Thankyou,
Eric Moore