2023-09-25 21:37:14

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH] spi: dt-bindings: Make "additionalProperties: true" explicit

Make it explicit that child nodes have additional properties and the
child node schema is not complete. The complete schemas are applied
separately based the compatible strings.

Signed-off-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml | 2 ++
.../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml | 2 ++
Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 1 +
Documentation/devicetree/bindings/spi/rockchip-sfc.yaml | 2 ++
Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++
5 files changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
index a6f34bdd1d3c..e1ab3f523ad6 100644
--- a/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
@@ -46,6 +46,8 @@ properties:
patternProperties:
"^.*@[0-9a-f]+":
type: object
+ additionalProperties: true
+
properties:
reg:
items:
diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
index 28b8ace63044..3b47b68b92cb 100644
--- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
@@ -68,6 +68,8 @@ properties:
patternProperties:
"^.*@[0-9a-f]+":
type: object
+ additionalProperties: true
+
properties:
reg:
items:
diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
index 9ae1611175f2..48e97e240265 100644
--- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
+++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
@@ -50,6 +50,7 @@ properties:
patternProperties:
"@[0-9a-f]+$":
type: object
+ additionalProperties: true

properties:
spi-rx-bus-width:
diff --git a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
index 339fb39529f3..ac1503de0478 100644
--- a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
+++ b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
@@ -47,6 +47,8 @@ properties:
patternProperties:
"^flash@[0-3]$":
type: object
+ additionalProperties: true
+
properties:
reg:
minimum: 0
diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
index a47cb144b09f..6348a387a21c 100644
--- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
+++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
@@ -160,6 +160,8 @@ properties:
patternProperties:
"^.*@[0-9a-f]+$":
type: object
+ additionalProperties: true
+
properties:
reg:
minimum: 0
--
2.40.1


2023-09-26 05:25:13

by Jernej Škrabec

[permalink] [raw]
Subject: Re: [PATCH] spi: dt-bindings: Make "additionalProperties: true" explicit

Dne ponedeljek, 25. september 2023 ob 23:26:00 CEST je Rob Herring napisal(a):
> Make it explicit that child nodes have additional properties and the
> child node schema is not complete. The complete schemas are applied
> separately based the compatible strings.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> .../devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml | 2 ++
> .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml | 2 ++

For Allwinner:
Acked-by: Jernej Skrabec <[email protected]>

Best regards,
Jernej

> Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 1 +
> Documentation/devicetree/bindings/spi/rockchip-sfc.yaml | 2 ++
> Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++
> 5 files changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
> index a6f34bdd1d3c..e1ab3f523ad6 100644
> --- a/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
> @@ -46,6 +46,8 @@ properties:
> patternProperties:
> "^.*@[0-9a-f]+":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> items:
> diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> index 28b8ace63044..3b47b68b92cb 100644
> --- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> @@ -68,6 +68,8 @@ properties:
> patternProperties:
> "^.*@[0-9a-f]+":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> items:
> diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> index 9ae1611175f2..48e97e240265 100644
> --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> @@ -50,6 +50,7 @@ properties:
> patternProperties:
> "@[0-9a-f]+$":
> type: object
> + additionalProperties: true
>
> properties:
> spi-rx-bus-width:
> diff --git a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> index 339fb39529f3..ac1503de0478 100644
> --- a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> +++ b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> @@ -47,6 +47,8 @@ properties:
> patternProperties:
> "^flash@[0-3]$":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> minimum: 0
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index a47cb144b09f..6348a387a21c 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -160,6 +160,8 @@ properties:
> patternProperties:
> "^.*@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> minimum: 0
>




2023-09-26 13:27:49

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] spi: dt-bindings: Make "additionalProperties: true" explicit

On Mon, Sep 25, 2023 at 04:26:00PM -0500, Rob Herring wrote:
> Make it explicit that child nodes have additional properties and the
> child node schema is not complete. The complete schemas are applied
> separately based the compatible strings.
>
> Signed-off-by: Rob Herring <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

> ---
> .../devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml | 2 ++
> .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml | 2 ++
> Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 1 +
> Documentation/devicetree/bindings/spi/rockchip-sfc.yaml | 2 ++
> Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++
> 5 files changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
> index a6f34bdd1d3c..e1ab3f523ad6 100644
> --- a/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
> @@ -46,6 +46,8 @@ properties:
> patternProperties:
> "^.*@[0-9a-f]+":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> items:
> diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> index 28b8ace63044..3b47b68b92cb 100644
> --- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> @@ -68,6 +68,8 @@ properties:
> patternProperties:
> "^.*@[0-9a-f]+":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> items:
> diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> index 9ae1611175f2..48e97e240265 100644
> --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> @@ -50,6 +50,7 @@ properties:
> patternProperties:
> "@[0-9a-f]+$":
> type: object
> + additionalProperties: true
>
> properties:
> spi-rx-bus-width:
> diff --git a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> index 339fb39529f3..ac1503de0478 100644
> --- a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> +++ b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> @@ -47,6 +47,8 @@ properties:
> patternProperties:
> "^flash@[0-3]$":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> minimum: 0
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index a47cb144b09f..6348a387a21c 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -160,6 +160,8 @@ properties:
> patternProperties:
> "^.*@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> minimum: 0
> --
> 2.40.1
>


Attachments:
(No filename) (3.36 kB)
signature.asc (235.00 B)
Download all attachments

2023-09-26 13:28:30

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] spi: dt-bindings: Make "additionalProperties: true" explicit

On Mon, 25 Sep 2023 16:26:00 -0500, Rob Herring wrote:
> Make it explicit that child nodes have additional properties and the
> child node schema is not complete. The complete schemas are applied
> separately based the compatible strings.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: dt-bindings: Make "additionalProperties: true" explicit
commit: 9f778f377cd3b8d6699025ea75732ca91a239cd1

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

2023-09-26 13:32:23

by Serge Semin

[permalink] [raw]
Subject: Re: [PATCH] spi: dt-bindings: Make "additionalProperties: true" explicit

On Mon, Sep 25, 2023 at 04:26:00PM -0500, Rob Herring wrote:
> Make it explicit that child nodes have additional properties and the
> child node schema is not complete. The complete schemas are applied
> separately based the compatible strings.
>
> Signed-off-by: Rob Herring <[email protected]>

For the DW APB/AHB SSI bindings:
Acked-by: Serge Semin <[email protected]>

-Serge(y)

> ---
> .../devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml | 2 ++
> .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml | 2 ++
> Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 1 +
> Documentation/devicetree/bindings/spi/rockchip-sfc.yaml | 2 ++
> Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++
> 5 files changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
> index a6f34bdd1d3c..e1ab3f523ad6 100644
> --- a/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
> @@ -46,6 +46,8 @@ properties:
> patternProperties:
> "^.*@[0-9a-f]+":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> items:
> diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> index 28b8ace63044..3b47b68b92cb 100644
> --- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> @@ -68,6 +68,8 @@ properties:
> patternProperties:
> "^.*@[0-9a-f]+":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> items:
> diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> index 9ae1611175f2..48e97e240265 100644
> --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> @@ -50,6 +50,7 @@ properties:
> patternProperties:
> "@[0-9a-f]+$":
> type: object
> + additionalProperties: true
>
> properties:
> spi-rx-bus-width:
> diff --git a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> index 339fb39529f3..ac1503de0478 100644
> --- a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> +++ b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> @@ -47,6 +47,8 @@ properties:
> patternProperties:
> "^flash@[0-3]$":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> minimum: 0
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index a47cb144b09f..6348a387a21c 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -160,6 +160,8 @@ properties:
> patternProperties:
> "^.*@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> minimum: 0
> --
> 2.40.1
>

2023-10-05 16:17:24

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH] spi: dt-bindings: Make "additionalProperties: true" explicit

Am Montag, 25. September 2023, 23:26:00 CEST schrieb Rob Herring:
> Make it explicit that child nodes have additional properties and the
> child node schema is not complete. The complete schemas are applied
> separately based the compatible strings.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/spi/rockchip-sfc.yaml | 2 ++

> diff --git a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> index 339fb39529f3..ac1503de0478 100644
> --- a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> +++ b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> @@ -47,6 +47,8 @@ properties:
> patternProperties:
> "^flash@[0-3]$":
> type: object
> + additionalProperties: true
> +
> properties:
> reg:
> minimum: 0

For rockchip-sfc:
Acked-by: Heiko Stuebner <[email protected]>