2021-06-09 17:17:18

by Jon Maloy

[permalink] [raw]
Subject: Re: [PATCH v2 net-next 0/2] net: tipc: fix FB_MTU eat two pages and do some code cleanup



On 6/9/21 6:32 AM, [email protected] wrote:
> From: Menglong Dong <[email protected]>
>
> In the first patch, FB_MTU is redefined to make sure data size will not
> exceed PAGE_SIZE. Besides, I removed the alignment for buf_size in
> tipc_buf_acquire, because skb_alloc_fclone will do the alignment job.
>
> In the second patch, I removed align() in msg.c and replace it with
> ALIGN().
>
>
>
>
> Menglong Dong (2):
> net: tipc: fix FB_MTU eat two pages
> net: tipc: replace align() with ALIGN in msg.c
>
> net/tipc/bcast.c | 2 +-
> net/tipc/msg.c | 31 ++++++++++++++-----------------
> net/tipc/msg.h | 3 ++-
> 3 files changed, 17 insertions(+), 19 deletions(-)
>
NACK.
You must have missed my last mail before you sent out this.  We have to
define a separate macro for bcast.c, since those buffers sometimes will
need encryption.
Sorry for the confusion.
///jon