2023-03-06 04:00:48

by Randy Dunlap

Subject: [PATCH 2/7 v4] sh: nmi_debug: fix return value of __setup handler

__setup() handlers should return 1 to obsolete_checksetup() in
init/main.c to indicate that the boot option has been handled.
A return of 0 causes the boot option/value to be listed as an Unknown
kernel parameter and added to init's (limited) argument or environment
strings. Also, error return codes don't mean anything to
obsolete_checksetup() -- only non-zero (usually 1) or zero.
So return 1 from nmi_debug_setup().

Fixes: 1e1030dccb10 ("sh: nmi_debug support.")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: Igor Zhbanov <[email protected]>
Link: lore.kernel.org/r/[email protected]
Cc: John Paul Adrian Glaubitz <[email protected]>
Cc: Yoshinori Sato <[email protected]>
Cc: Rich Felker <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
v2: add more Cc's;
refresh and resend;
v3: add Arnd to Cc: list
v4: update Cc: list, refresh & resend

arch/sh/kernel/nmi_debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff -- a/arch/sh/kernel/nmi_debug.c b/arch/sh/kernel/nmi_debug.c
--- a/arch/sh/kernel/nmi_debug.c
+++ b/arch/sh/kernel/nmi_debug.c
@@ -49,7 +49,7 @@ static int __init nmi_debug_setup(char *
register_die_notifier(&nmi_debug_nb);

if (*str != '=')
- return 0;
+ return 1;

for (p = str + 1; *p; p = sep + 1) {
sep = strchr(p, ',');
@@ -70,6 +70,6 @@ static int __init nmi_debug_setup(char *
break;
}

- return 0;
+ return 1;
}
__setup("nmi_debug", nmi_debug_setup);

2023-03-19 19:32:55

by John Paul Adrian Glaubitz

Subject: Re: [PATCH 2/7 v4] sh: nmi_debug: fix return value of __setup handler

On Sun, 2023-03-05 at 20:00 -0800, Randy Dunlap wrote:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) argument or environment
> strings. Also, error return codes don't mean anything to
> obsolete_checksetup() -- only non-zero (usually 1) or zero.
> So return 1 from nmi_debug_setup().
>
> Fixes: 1e1030dccb10 ("sh: nmi_debug support.")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: Igor Zhbanov <[email protected]>
> Link: lore.kernel.org/r/[email protected]
> Cc: John Paul Adrian Glaubitz <[email protected]>
> Cc: Yoshinori Sato <[email protected]>
> Cc: Rich Felker <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> v2: add more Cc's;
> refresh and resend;
> v3: add Arnd to Cc: list
> v4: update Cc: list, refresh & resend
>
> arch/sh/kernel/nmi_debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -- a/arch/sh/kernel/nmi_debug.c b/arch/sh/kernel/nmi_debug.c
> --- a/arch/sh/kernel/nmi_debug.c
> +++ b/arch/sh/kernel/nmi_debug.c
> @@ -49,7 +49,7 @@ static int __init nmi_debug_setup(char *
> register_die_notifier(&nmi_debug_nb);
>
> if (*str != '=')
> - return 0;
> + return 1;
>
> for (p = str + 1; *p; p = sep + 1) {
> sep = strchr(p, ',');
> @@ -70,6 +70,6 @@ static int __init nmi_debug_setup(char *
> break;
> }
>
> - return 0;
> + return 1;
> }
> __setup("nmi_debug", nmi_debug_setup);

Reviewed-by: John Paul Adrian Glaubitz <[email protected]>

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913