Drop incorrect and unused serial properties - address/size-cells and
reg-names:
sa8155p-adp.dtb: geniqup@ac0000: serial@a84000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'reg-names' were unexpected)
Reviewed-by: Konrad Dybcio <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. Add Rb tag.
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 27dcda0d4288..3846f5e0f656 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1362,14 +1362,11 @@ spi9: spi@a84000 {
uart9: serial@a84000 {
compatible = "qcom,geni-uart";
reg = <0x0 0x00a84000 0x0 0x4000>;
- reg-names = "se";
clocks = <&gcc GCC_QUPV3_WRAP1_S1_CLK>;
clock-names = "se";
pinctrl-0 = <&qup_uart9_default>;
pinctrl-names = "default";
interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
};
--
2.34.1
Since commit 6c84bbd103d8 ("dt-bindings: arm-smmu: Add generic
qcom,smmu-500 bindings") the SMMU is supposed to use qcom,smmu-500
compatible fallback.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. Correct compatible and commit msg (Konrad).
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 3846f5e0f656..25085621ef49 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -3983,7 +3983,7 @@ spmi_bus: spmi@c440000 {
};
apps_smmu: iommu@15000000 {
- compatible = "qcom,sm8150-smmu-500", "arm,mmu-500";
+ compatible = "qcom,sm8150-smmu-500", "qcom,smmu-500", "arm,mmu-500";
reg = <0 0x15000000 0 0x100000>;
#iommu-cells = <2>;
#global-interrupts = <1>;
--
2.34.1
Qualcomm PCI express root complex does not use snps,dw-pcie fallback:
['qcom,pcie-sm8150', 'snps,dw-pcie'] is too long
Reviewed-by: Konrad Dybcio <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. Add Rb tag.
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 25085621ef49..a7f7bbfefa5b 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1823,7 +1823,7 @@ dma@10a2000 {
};
pcie0: pci@1c00000 {
- compatible = "qcom,pcie-sm8150", "snps,dw-pcie";
+ compatible = "qcom,pcie-sm8150";
reg = <0 0x01c00000 0 0x3000>,
<0 0x60000000 0 0xf1d>,
<0 0x60000f20 0 0xa8>,
@@ -1918,7 +1918,7 @@ pcie0_lane: phy@1c06200 {
};
pcie1: pci@1c08000 {
- compatible = "qcom,pcie-sm8150", "snps,dw-pcie";
+ compatible = "qcom,pcie-sm8150";
reg = <0 0x01c08000 0 0x3000>,
<0 0x40000000 0 0xf1d>,
<0 0x40000f20 0 0xa8>,
--
2.34.1
GIC child node is supposed to be named msi-controller:
sa8295p-adp.dtb: interrupt-controller@17a00000: gic-its@17a40000: False schema does not allow
Reviewed-by: Konrad Dybcio <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. Add Rb tag.
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index a4e52fb72710..d999d1799f52 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -3904,7 +3904,7 @@ intc: interrupt-controller@17a00000 {
#size-cells = <2>;
ranges;
- gic-its@17a40000 {
+ msi-controller@17a40000 {
compatible = "arm,gic-v3-its";
reg = <0 0x17a40000 0 0x20000>;
msi-controller;
--
2.34.1
On 17.04.2023 10:09, Krzysztof Kozlowski wrote:
> Since commit 6c84bbd103d8 ("dt-bindings: arm-smmu: Add generic
> qcom,smmu-500 bindings") the SMMU is supposed to use qcom,smmu-500
> compatible fallback.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>
Konrad
>
> Changes since v1:
> 1. Correct compatible and commit msg (Konrad).
> ---
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 3846f5e0f656..25085621ef49 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -3983,7 +3983,7 @@ spmi_bus: spmi@c440000 {
> };
>
> apps_smmu: iommu@15000000 {
> - compatible = "qcom,sm8150-smmu-500", "arm,mmu-500";
> + compatible = "qcom,sm8150-smmu-500", "qcom,smmu-500", "arm,mmu-500";
> reg = <0 0x15000000 0 0x100000>;
> #iommu-cells = <2>;
> #global-interrupts = <1>;
On Mon, 17 Apr 2023 10:08:15 +0200, Krzysztof Kozlowski wrote:
> Drop incorrect and unused serial properties - address/size-cells and
> reg-names:
>
> sa8155p-adp.dtb: geniqup@ac0000: serial@a84000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'reg-names' were unexpected)
>
>
Applied, thanks!
[1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties
commit: e10094bf590696a7f845790485cc3f753b2fd94a
[2/4] arm64: dts: qcom: sm8150: add missing qcom,smmu-500 fallback
commit: 83254172fa7f4d4a400f2ff441f111e424dd5ee0
[3/4] arm64: dts: qcom: sm8150: drop snps,dw-pcie fallback compatible
commit: 7df522338d63c42946eb82f8af7dba8c363bd725
[4/4] arm64: dts: qcom: sc8280xp: correct GIC child node name
commit: 9230758996c3ff0b5cf8e8506731c956bfb351bf
Best regards,
--
Bjorn Andersson <[email protected]>