2019-04-08 20:19:28

by Pavel Machek

[permalink] [raw]
Subject: Thinkpad X60: regression with 5.1-rc1 and 5.1-rc4

Hi!

For some reason, Thinkpad X60 now crashes during boot. I see some
weird backtraces, and it may be bfq related... or maybe ACPI idle.

Does x86-32 work for you?

Weird thing is, 5.1.0-rc3-next-20190408 boots here (but later has
problems during resume, making it unusable, too). They may not have
100% same configs.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


Attachments:
(No filename) (487.00 B)
signature.asc (188.00 B)
Digital signature
Download all attachments

2019-04-08 20:19:31

by Jens Axboe

[permalink] [raw]
Subject: Re: Thinkpad X60: regression with 5.1-rc1 and 5.1-rc4

On 4/8/19 11:39 AM, Pavel Machek wrote:
> Hi!
>
> For some reason, Thinkpad X60 now crashes during boot. I see some
> weird backtraces, and it may be bfq related... or maybe ACPI idle.
>
> Does x86-32 work for you?
>
> Weird thing is, 5.1.0-rc3-next-20190408 boots here (but later has
> problems during resume, making it unusable, too). They may not have
> 100% same configs.

Can you try and revert:

9dee8b3b057e1

and see if that helps?

--
Jens Axboe

2019-04-09 16:33:56

by Pavel Machek

[permalink] [raw]
Subject: Re: Thinkpad X60: regression with 5.1-rc1 and 5.1-rc4

On Mon 2019-04-08 11:41:18, Jens Axboe wrote:
> On 4/8/19 11:39 AM, Pavel Machek wrote:
> > Hi!
> >
> > For some reason, Thinkpad X60 now crashes during boot. I see some
> > weird backtraces, and it may be bfq related... or maybe ACPI idle.
> >
> > Does x86-32 work for you?
> >
> > Weird thing is, 5.1.0-rc3-next-20190408 boots here (but later has
> > problems during resume, making it unusable, too). They may not have
> > 100% same configs.

I now noticed it said:

EIP is in bfq_bfqq_expire

> Can you try and revert:
>
> 9dee8b3b057e1
>
> and see if that helps?

Yes, I tried and yes, it helps. What are the next steps?

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


Attachments:
(No filename) (814.00 B)
signature.asc (188.00 B)
Digital signature
Download all attachments

2019-04-09 16:36:36

by Paolo Valente

[permalink] [raw]
Subject: Re: Thinkpad X60: regression with 5.1-rc1 and 5.1-rc4



> Il giorno 9 apr 2019, alle ore 18:33, Pavel Machek <[email protected]> ha scritto:
>
> On Mon 2019-04-08 11:41:18, Jens Axboe wrote:
>> On 4/8/19 11:39 AM, Pavel Machek wrote:
>>> Hi!
>>>
>>> For some reason, Thinkpad X60 now crashes during boot. I see some
>>> weird backtraces, and it may be bfq related... or maybe ACPI idle.
>>>
>>> Does x86-32 work for you?
>>>
>>> Weird thing is, 5.1.0-rc3-next-20190408 boots here (but later has
>>> problems during resume, making it unusable, too). They may not have
>>> 100% same configs.
>
> I now noticed it said:
>
> EIP is in bfq_bfqq_expire
>
>> Can you try and revert:
>>
>> 9dee8b3b057e1
>>
>> and see if that helps?
>
> Yes, I tried and yes, it helps. What are the next steps?
>

Try my fix:

https://lore.kernel.org/linux-block/[email protected]/T/#m30a14045e710b870f00f7c51cdaa7c403977b767

and cross your fingers :)

Thanks,
Paolo

> Pavel
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2019-04-10 11:07:03

by Pavel Machek

[permalink] [raw]
Subject: Re: Thinkpad X60: regression with 5.1-rc1 and 5.1-rc4

Hi!

> > I now noticed it said:
> >
> > EIP is in bfq_bfqq_expire
> >
> >> Can you try and revert:
> >>
> >> 9dee8b3b057e1
> >>
> >> and see if that helps?
> >
> > Yes, I tried and yes, it helps. What are the next steps?
> >
>
> Try my fix:
>
> https://lore.kernel.org/linux-block/[email protected]/T/#m30a14045e710b870f00f7c51cdaa7c403977b767
>
> and cross your fingers :)

It seems to work... even without fingers crossed.

Tested-by: Pavel Machek <[email protected]>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


Attachments:
(No filename) (677.00 B)
signature.asc (188.00 B)
Digital signature
Download all attachments

2019-04-10 11:08:02

by Paolo Valente

[permalink] [raw]
Subject: Re: Thinkpad X60: regression with 5.1-rc1 and 5.1-rc4



> Il giorno 10 apr 2019, alle ore 11:30, Pavel Machek <[email protected]> ha scritto:
>
> Hi!
>
>>> I now noticed it said:
>>>
>>> EIP is in bfq_bfqq_expire
>>>
>>>> Can you try and revert:
>>>>
>>>> 9dee8b3b057e1
>>>>
>>>> and see if that helps?
>>>
>>> Yes, I tried and yes, it helps. What are the next steps?
>>>
>>
>> Try my fix:
>>
>> https://lore.kernel.org/linux-block/[email protected]/T/#m30a14045e710b870f00f7c51cdaa7c403977b767
>>
>> and cross your fingers :)
>
> It seems to work... even without fingers crossed.
>

Great! I've submitted a final version of this fix patch a few minutes
ago (not yet archived anywhere, sorry).

Thanks,
Paolo

> Tested-by: Pavel Machek <[email protected]>
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html