2024-04-14 10:25:07

by Sumadhura Kalyan

Subject: [PATCH] Replace function alignment of camel case by snake case.

Issue found by checkpatch

Signed-off-by: sumadhura kalyan <[email protected]>
---
.../vc04_services/vchiq-mmal/mmal-vchiq.h | 29 +++++++------------
1 file changed, 11 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h
index 09f030919d4e..98909fde978e 100644
--- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h
+++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h
@@ -42,8 +42,7 @@ struct vchiq_mmal_port_buffer {

struct vchiq_mmal_port;

-typedef void (*vchiq_mmal_buffer_cb)(
- struct vchiq_mmal_instance *instance,
+typedef void (*vchiq_mmal_buffer_cb)(struct vchiq_mmal_instance *instance,
struct vchiq_mmal_port *port,
int status, struct mmal_buffer *buffer);

@@ -101,31 +100,25 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance);
/* Initialise a mmal component and its ports
*
*/
-int vchiq_mmal_component_init(
- struct vchiq_mmal_instance *instance,
- const char *name,
- struct vchiq_mmal_component **component_out);
+int vchiq_mmal_component_init(struct vchiq_mmal_instance *instance,
+ const char *name, struct vchiq_mmal_component **component_out);

-int vchiq_mmal_component_finalise(
- struct vchiq_mmal_instance *instance,
- struct vchiq_mmal_component *component);
+int vchiq_mmal_component_finalise(struct vchiq_mmal_instance *instance,
+ struct vchiq_mmal_component *component);

-int vchiq_mmal_component_enable(
- struct vchiq_mmal_instance *instance,
- struct vchiq_mmal_component *component);
+int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance,
+ struct vchiq_mmal_component *component);

-int vchiq_mmal_component_disable(
- struct vchiq_mmal_instance *instance,
- struct vchiq_mmal_component *component);
+int vchiq_mmal_component_disable(struct vchiq_mmal_instance *instance,
+ struct vchiq_mmal_component *component);

/* enable a mmal port
*
* enables a port and if a buffer callback provided enque buffer
* headers as appropriate for the port.
*/
-int vchiq_mmal_port_enable(
- struct vchiq_mmal_instance *instance,
- struct vchiq_mmal_port *port,
+int vchiq_mmal_port_enable(struct vchiq_mmal_instance *instance,
+ struct vchiq_mmal_port *port,
vchiq_mmal_buffer_cb buffer_cb);

/* disable a port
--
2.25.1

2024-04-14 10:57:24

by Greg KH

Subject: Re: [PATCH] Replace function alignment of camel case by snake case.

On Sun, Apr 14, 2024 at 03:54:42PM +0530, sumadhura kalyan wrote:
> Issue found by checkpatch
>
> Signed-off-by: sumadhura kalyan <[email protected]>

Your subject line is wrong.

2024-04-14 11:56:41

by Dan Carpenter

Subject: Re: [PATCH] Replace function alignment of camel case by snake case.

On Sun, Apr 14, 2024 at 03:54:42PM +0530, sumadhura kalyan wrote:
> Issue found by checkpatch
^^^^^^^^^^^^^^^^^^^^^^^^^
What is the issue? Keep in mind that when people are reading email they
often don't see the Subject so it's fine to restate things.

Look how your patch looks to reviewers:
https://lore.kernel.org/linux-staging/2024041457-outshoot-voyage-3e5b@gregkh/T/#t

regards,
dan carpenter