On Wed, 2022-06-01 at 15:37 +0000, Benjamin Beichler wrote:
> If VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS is activated, the user mode
> linux virtio irq handler only read one msg from the corresponding socket.
> This creates issues, when the device emulation creates multiple call
> requests (e.g. for multiple virtqueues), as the socket buffer tend to fill
> up and the call requests are delayed.
>
> This creates a deadlock situation, when the device simulation blocks,
> because of sending a msg and the kernel side blocks because of
> synchronously waiting for an acknowledge of kick request.
>
> Actually inband notifications are meant to be used in combination with the
> time travel protocol, but it is not required, therefore this corner case
> needs to be handled.
Hmm. How did you run into this? Why would a device send many messages
and not wait for ACK, but the kernel side actually waits for ACK? What
would the use case for that be? Seems a bit odd, if both wait for ACK
there shouldn't be an issue?
Anyway, I guess I don't mind fixing this regardless of whether I see a
use case where it could happen :-)
> +++ b/arch/um/drivers/virtio_uml.c
> @@ -363,45 +363,47 @@ static irqreturn_t vu_req_read_message(struct virtio_uml_device *vu_dev,
> struct vhost_user_msg msg;
> u8 extra_payload[512];
> } msg;
> - int rc;
> -
> - rc = vhost_user_recv_req(vu_dev, &msg.msg,
> - sizeof(msg.msg.payload) +
> - sizeof(msg.extra_payload));
> -
> - if (rc)
This code changed a bit, you should rebase onto the uml tree's for-next
branch.
> + while (1) {
> + if (vhost_user_recv_req(vu_dev, &msg.msg,
> + sizeof(msg.msg.payload)
> + + sizeof(msg.extra_payload)))
prefer to keep the + on the previous line.
That said, my attempt at rebasing this made it all fail completely,
maybe you have better luck :)
johannes
Am 01.06.2022 um 19:13 schrieb Johannes Berg:
> On Wed, 2022-06-01 at 15:37 +0000, Benjamin Beichler wrote:
>
> Hmm. How did you run into this? Why would a device send many messages
> and not wait for ACK, but the kernel side actually waits for ACK? What
> would the use case for that be? Seems a bit odd, if both wait for ACK
> there shouldn't be an issue?
>
> Anyway, I guess I don't mind fixing this regardless of whether I see a
> use case where it could happen :-)
Here is my (admittedly maybe odd) case:
I want to use hwsim over virtio with UML but without time travel (as a
precursor for a later version with TT)
I modified wmediumd to strip out the scheduler dependency and wrote a
very simple simulation, which simply forwards all frames to all radios.
Furthermore, I use the usfstl "loop" as main driver to poll all fds
without time travel. This leads to the situation, that when a msg is put
on the RX-ring of an uml instance, which also sent concurrently a kick
(e.g., also trying to send a frame), this creates a deadlock. In the
original wmediumd this was handled by kind of a hack, calling the loop
implementation to answer the kick, before sending out a call msg. I need
to rip out this workaround, because without the usfstl scheduler, it
created a deep recursion of the loop implementation with additional
problems.
Nonetheless, even if this would be kind of an optimization: it is
feasible to wait for the ACK asynchronously, as long as it arrives in
the same point of simulation time (or as you called it calender). For
many uml-instances, which could easily run in parallel, this allows an
easier implementation (at least in my planning :-) ). Of course, it
would be hard to distinguish, which call-request was acked, but at the
end wmediumd (and I also plan to do so) simply aborts when the ack is
negative, so the actual corresponding call is not that important to know.
>
> This code changed a bit, you should rebase onto the uml tree's for-next
> branch.
My bad, I was not expecting someone to change something it that corner
of the kernel, I only used the latest master and not the next. I will
redo the patch with ease.
>
>> + while (1) {
>> + if (vhost_user_recv_req(vu_dev, &msg.msg,
>> + sizeof(msg.msg.payload)
>> + + sizeof(msg.extra_payload)))
> prefer to keep the + on the previous line.
>
It slightly hits the 80 column restriction, but I would also prefer not
to break. :-D
> That said, my attempt at rebasing this made it all fail completely,
> maybe you have better luck :)
>
> johannes
>
kind regards
Benjamin
--
M.Sc. Benjamin Beichler
Universität Rostock, Fakultät für Informatik und Elektrotechnik
Institut für Angewandte Mikroelektronik und Datentechnik
University of Rostock, Department of CS and EE
Institute of Applied Microelectronics and CE
Richard-Wagner-Straße 31
18119 Rostock
Deutschland/Germany
phone: +49 (0) 381 498 - 7278
email:[email protected]
www:http://www.imd.uni-rostock.de/