2020-05-12 17:15:47

by Colin King

Subject: [PATCH][next] sfc: fix dereference of table before it is null checked

From: Colin Ian King <[email protected]>

Currently pointer table is being dereferenced on a null check of
table->must_restore_filters before it is being null checked, leading
to a potential null pointer dereference issue. Fix this by null
checking table before dereferencing it when checking for a null
table->must_restore_filters.

Addresses-Coverity: ("Dereference before null check")
Fixes: e4fe938cff04 ("sfc: move 'must restore' flags out of ef10-specific nic_data")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/sfc/mcdi_filters.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/sfc/mcdi_filters.c b/drivers/net/ethernet/sfc/mcdi_filters.c
index 88de95a8c08c..455a62814fb9 100644
--- a/drivers/net/ethernet/sfc/mcdi_filters.c
+++ b/drivers/net/ethernet/sfc/mcdi_filters.c
@@ -1369,10 +1369,7 @@ void efx_mcdi_filter_table_restore(struct efx_nic *efx)

WARN_ON(!rwsem_is_locked(&efx->filter_sem));

- if (!table->must_restore_filters)
- return;
-
- if (!table)
+ if (!table || !table->must_restore_filters)
return;

down_write(&table->lock);
--
2.25.1

2020-05-13 09:42:13

by Edward Cree

Subject: Re: [PATCH][next] sfc: fix dereference of table before it is null checked

On 12/05/2020 18:13, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Currently pointer table is being dereferenced on a null check of
> table->must_restore_filters before it is being null checked, leading
> to a potential null pointer dereference issue. Fix this by null
> checking table before dereferencing it when checking for a null
> table->must_restore_filters.
>
> Addresses-Coverity: ("Dereference before null check")
> Fixes: e4fe938cff04 ("sfc: move 'must restore' flags out of ef10-specific nic_data")
> Signed-off-by: Colin Ian King <[email protected]>
Acked-by: Edward Cree <[email protected]>

2020-05-13 22:22:23

by David Miller

Subject: Re: [PATCH][next] sfc: fix dereference of table before it is null checked

From: Colin King <[email protected]>
Date: Tue, 12 May 2020 18:13:55 +0100

> From: Colin Ian King <[email protected]>
>
> Currently pointer table is being dereferenced on a null check of
> table->must_restore_filters before it is being null checked, leading
> to a potential null pointer dereference issue. Fix this by null
> checking table before dereferencing it when checking for a null
> table->must_restore_filters.
>
> Addresses-Coverity: ("Dereference before null check")
> Fixes: e4fe938cff04 ("sfc: move 'must restore' flags out of ef10-specific nic_data")
> Signed-off-by: Colin Ian King <[email protected]>

Applied, thanks.