2018-10-09 21:37:44

by Otavio Salvador

Subject: [PATCH] ARM: dts: rv1108-evb: enable eMMC support

Enable eMMC support for rv1108 evaluation board.

Signed-off-by: Otavio Salvador <[email protected]>
---

arch/arm/boot/dts/rv1108-evb.dts | 8 ++++++++
arch/arm/boot/dts/rv1108.dtsi | 29 +++++++++++++++++++++++++++++
2 files changed, 37 insertions(+)

diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
index 70f0106d1252..f3c6f52c49e6 100644
--- a/arch/arm/boot/dts/rv1108-evb.dts
+++ b/arch/arm/boot/dts/rv1108-evb.dts
@@ -226,6 +226,14 @@
status = "okay";
};

+&emmc {
+ cap-mmc-highspeed;
+ supports-emmc;
+ non-removable;
+ num-slots = <1>;
+ status = "okay";
+};
+
&u2phy {
status = "okay";

diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 76ea24636feb..f14a733d85f6 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -772,6 +772,35 @@
};
};

+ emmc {
+ emmc_clk: emmc-clk {
+ rockchip,pins = <2 RK_PB6 RK_FUNC_1 &pcfg_pull_none_drv_8ma>;
+ };
+
+ emmc_cmd: emmc-cmd {
+ rockchip,pins = <2 RK_PB4 RK_FUNC_2 &pcfg_pull_up_drv_8ma>;
+ };
+
+ emmc_pwren: emmc-pwren {
+ rockchip,pins = <2 RK_PC2 RK_FUNC_2 &pcfg_pull_none>;
+ };
+
+ emmc_bus1: emmc-bus1 {
+ rockchip,pins = <2 RK_PA0 RK_FUNC_2 &pcfg_pull_up_drv_8ma>;
+ };
+
+ emmc_bus8: emmc-bus8 {
+ rockchip,pins = <2 RK_PA0 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
+ <2 RK_PA1 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
+ <2 RK_PA2 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
+ <2 RK_PA3 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
+ <2 RK_PA4 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
+ <2 RK_PA5 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
+ <2 RK_PA6 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
+ <2 RK_PA7 RK_FUNC_2 &pcfg_pull_up_drv_8ma>;
+ };
+ };
+
sdmmc {
sdmmc_clk: sdmmc-clk {
rockchip,pins = <3 RK_PC4 RK_FUNC_1 &pcfg_pull_none_drv_4ma>;
--
2.19.0

2018-10-16 13:10:40

by Heiko Stuebner

Subject: Re: [PATCH] ARM: dts: rv1108-evb: enable eMMC support

Hi Otavio,

Am Dienstag, 9. Oktober 2018, 23:36:56 CEST schrieb Otavio Salvador:
> Enable eMMC support for rv1108 evaluation board.
>
> Signed-off-by: Otavio Salvador <[email protected]>
> ---
>
> arch/arm/boot/dts/rv1108-evb.dts | 8 ++++++++
> arch/arm/boot/dts/rv1108.dtsi | 29 +++++++++++++++++++++++++++++
> 2 files changed, 37 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
> index 70f0106d1252..f3c6f52c49e6 100644
> --- a/arch/arm/boot/dts/rv1108-evb.dts
> +++ b/arch/arm/boot/dts/rv1108-evb.dts
> @@ -226,6 +226,14 @@
> status = "okay";
> };
>
> +&emmc {
> + cap-mmc-highspeed;
> + supports-emmc;
> + non-removable;
> + num-slots = <1>;

num-slots should not be present anymore on new additions

Also missing the pinctrl settings you're defining below?
Aka pinctrl-0 = <&emmc_*>; + pinctrl-names = "default"


Heiko

> + status = "okay";
> +};
> +
> &u2phy {
> status = "okay";
>
> diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
> index 76ea24636feb..f14a733d85f6 100644
> --- a/arch/arm/boot/dts/rv1108.dtsi
> +++ b/arch/arm/boot/dts/rv1108.dtsi
> @@ -772,6 +772,35 @@
> };
> };
>
> + emmc {
> + emmc_clk: emmc-clk {
> + rockchip,pins = <2 RK_PB6 RK_FUNC_1 &pcfg_pull_none_drv_8ma>;
> + };
> +
> + emmc_cmd: emmc-cmd {
> + rockchip,pins = <2 RK_PB4 RK_FUNC_2 &pcfg_pull_up_drv_8ma>;
> + };
> +
> + emmc_pwren: emmc-pwren {
> + rockchip,pins = <2 RK_PC2 RK_FUNC_2 &pcfg_pull_none>;
> + };
> +
> + emmc_bus1: emmc-bus1 {
> + rockchip,pins = <2 RK_PA0 RK_FUNC_2 &pcfg_pull_up_drv_8ma>;
> + };
> +
> + emmc_bus8: emmc-bus8 {
> + rockchip,pins = <2 RK_PA0 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA1 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA2 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA3 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA4 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA5 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA6 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA7 RK_FUNC_2 &pcfg_pull_up_drv_8ma>;
> + };
> + };
> +
> sdmmc {
> sdmmc_clk: sdmmc-clk {
> rockchip,pins = <3 RK_PC4 RK_FUNC_1 &pcfg_pull_none_drv_4ma>;
>

2018-11-25 20:54:16

by Otavio Salvador

Subject: Re: [PATCH] ARM: dts: rv1108-evb: enable eMMC support

Hi Heiko,
On Tue, Oct 16, 2018 at 10:09 AM Heiko Stuebner <[email protected]> wrote:
> Am Dienstag, 9. Oktober 2018, 23:36:56 CEST schrieb Otavio Salvador:
> > Enable eMMC support for rv1108 evaluation board.
> >
> > Signed-off-by: Otavio Salvador <[email protected]>
> > ---
> >
> > arch/arm/boot/dts/rv1108-evb.dts | 8 ++++++++
> > arch/arm/boot/dts/rv1108.dtsi | 29 +++++++++++++++++++++++++++++
> > 2 files changed, 37 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
> > index 70f0106d1252..f3c6f52c49e6 100644
> > --- a/arch/arm/boot/dts/rv1108-evb.dts
> > +++ b/arch/arm/boot/dts/rv1108-evb.dts
> > @@ -226,6 +226,14 @@
> > status = "okay";
> > };
> >
> > +&emmc {
> > + cap-mmc-highspeed;
> > + supports-emmc;
> > + non-removable;
> > + num-slots = <1>;
>
> num-slots should not be present anymore on new additions
>
> Also missing the pinctrl settings you're defining below?
> Aka pinctrl-0 = <&emmc_*>; + pinctrl-names = "default"

Thank you, I am preparing a v2 of this patch together with few more changes.


--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750