2018-01-15 14:00:19

by SF Markus Elfring

Subject: [PATCH 0/2] mfd/rc5t583: Adjustments for rc5t583_i2c_probe()

From: Markus Elfring <[email protected]>
Date: Mon, 15 Jan 2018 14:57:28 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/mfd/rc5t583.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--
2.15.1

2018-01-15 14:01:16

by SF Markus Elfring

Subject: [PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_probe()

From: Markus Elfring <[email protected]>
Date: Mon, 15 Jan 2018 14:48:57 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mfd/rc5t583.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/rc5t583.c b/drivers/mfd/rc5t583.c
index d12243d5ecb8..411dba636a53 100644
--- a/drivers/mfd/rc5t583.c
+++ b/drivers/mfd/rc5t583.c
@@ -259,10 +259,8 @@ static int rc5t583_i2c_probe(struct i2c_client *i2c,
}

rc5t583 = devm_kzalloc(&i2c->dev, sizeof(struct rc5t583), GFP_KERNEL);
- if (!rc5t583) {
- dev_err(&i2c->dev, "Memory allocation failed\n");
+ if (!rc5t583)
return -ENOMEM;
- }

rc5t583->dev = &i2c->dev;
i2c_set_clientdata(i2c, rc5t583);
--
2.15.1

2018-01-15 14:02:11

by SF Markus Elfring

Subject: [PATCH 2/2] mfd/rc5t583: Improve a size determination in rc5t583_i2c_probe()

From: Markus Elfring <[email protected]>
Date: Mon, 15 Jan 2018 14:50:25 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mfd/rc5t583.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/rc5t583.c b/drivers/mfd/rc5t583.c
index 411dba636a53..fd46de02b715 100644
--- a/drivers/mfd/rc5t583.c
+++ b/drivers/mfd/rc5t583.c
@@ -258,7 +258,7 @@ static int rc5t583_i2c_probe(struct i2c_client *i2c,
return -EINVAL;
}

- rc5t583 = devm_kzalloc(&i2c->dev, sizeof(struct rc5t583), GFP_KERNEL);
+ rc5t583 = devm_kzalloc(&i2c->dev, sizeof(*rc5t583), GFP_KERNEL);
if (!rc5t583)
return -ENOMEM;

--
2.15.1

2018-01-22 15:46:34

by Lee Jones

Subject: Re: [PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_probe()

On Mon, 15 Jan 2018, SF Markus Elfring wrote:

> From: Markus Elfring <[email protected]>
> Date: Mon, 15 Jan 2018 14:48:57 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/mfd/rc5t583.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2018-01-22 15:47:29

by Lee Jones

Subject: Re: [PATCH 2/2] mfd/rc5t583: Improve a size determination in rc5t583_i2c_probe()

On Mon, 15 Jan 2018, SF Markus Elfring wrote:

> From: Markus Elfring <[email protected]>
> Date: Mon, 15 Jan 2018 14:50:25 +0100
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/mfd/rc5t583.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog