2022-06-06 04:34:15

by Qi Zheng

[permalink] [raw]
Subject: Re: [PATCH] mm: memcontrol: separate {pgscan,pgsteal}_{kswapd,direct} items in memory.stat of cgroup v2



On 2022/6/4 8:47 AM, Shakeel Butt wrote:
> On Fri, Jun 3, 2022 at 12:06 AM Qi Zheng <[email protected]> wrote:
>>
> [...]
>>
>> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
>> index 176298f2f4de..0b9ca7e7df34 100644
>> --- a/Documentation/admin-guide/cgroup-v2.rst
>> +++ b/Documentation/admin-guide/cgroup-v2.rst
>> @@ -1442,11 +1442,17 @@ PAGE_SIZE multiple when read back.
>> pgrefill (npn)
>> Amount of scanned pages (in an active LRU list)
>>
>> - pgscan (npn)
>> - Amount of scanned pages (in an inactive LRU list)
>> + pgscan_kswapd (npn)
>> + Amount of scanned pages by kswapd (in an inactive LRU list)
>>
>> - pgsteal (npn)
>> - Amount of reclaimed pages
>> + pgscan_direct (npn)
>> + Amount of scanned pages directly (in an inactive LRU list)
>> +
>> + pgsteal_kswapd (npn)
>> + Amount of reclaimed pages by kswapd
>> +
>> + pgsteal_direct (npn)
>> + Amount of reclaimed pages directly
>
> No objection to adding new fields but removing 'pgsteal' and 'pgscan'
> from the user visible API might break some applications.

Oh, got it. So do we need to keep pgscan and pgsteal fields? If it is, I
can add it back in patch v2.

Thanks,
Qi