LinuxLists.cc - [PATCH 2.6 stallion.c] RFT added class support to stallion.c

2004-03-20 02:08:22

Subject: [PATCH 2.6 stallion.c] RFT added class support to stallion.c

Here is a patch to add class support to the Stallion multiport
serial driver.

I have verified it compiles but do not have the hardware.
If you can please verify, thanks.

Please consider for Inclusion or Testing.

Hanna
---
diff -Nrup linux-2.6.4/drivers/char/stallion.c linux-2.6.4p/drivers/char/stallion.c
--- linux-2.6.4/drivers/char/stallion.c 2004-03-10 18:55:37.000000000 -0800
+++ linux-2.6.4p/drivers/char/stallion.c 2004-03-19 17:28:08.000000000 -0800
@@ -41,6 +41,7 @@
#include <linux/init.h>
#include <linux/smp_lock.h>
#include <linux/devfs_fs_kernel.h>
+#include <linux/device.h>

#include <asm/io.h>
#include <asm/uaccess.h>
@@ -732,6 +733,8 @@ static struct file_operations stl_fsiome

/*****************************************************************************/

+static struct class_simple *stallion_class;
+
#ifdef MODULE

/*
@@ -788,12 +791,15 @@ static void __exit stallion_module_exit(
restore_flags(flags);
return;
}
- for (i = 0; i < 4; i++)
+ for (i = 0; i < 4; i++) {
devfs_remove("staliomem/%d", i);
+ class_simple_device_remove(MKDEV(STL_SIOMEMMAJOR, i));
+ }
devfs_remove("staliomem");
if ((i = unregister_chrdev(STL_SIOMEMMAJOR, "staliomem")))
printk("STALLION: failed to un-register serial memory device, "
"errno=%d\n", -i);
+ class_simple_destroy(stallion_class);

if (stl_tmpwritebuf != (char *) NULL)
kfree(stl_tmpwritebuf);
@@ -3181,10 +3187,12 @@ int __init stl_init(void)
printk("STALLION: failed to register serial board device\n");
devfs_mk_dir("staliomem");

+ stallion_class = class_simple_create(THIS_MODULE, "staliomem");
for (i = 0; i < 4; i++) {
devfs_mk_cdev(MKDEV(STL_SIOMEMMAJOR, i),
S_IFCHR|S_IRUSR|S_IWUSR,
"staliomem/%d", i);
+ class_simple_device_add(stallion_class, MKDEV(STL_SIOMEMMAJOR, i), NULL, "staliomem/%d", i);
}

stl_serial->owner = THIS_MODULE;

2004-03-21 12:38:14

by Greg Ungerer

[permalink] [raw]

Subject: Re: [PATCH 2.6 stallion.c] RFT added class support to stallion.c

Hi Hanna,

Hanna Linder wrote:
> Here is a patch to add class support to the Stallion multiport
> serial driver.
>
> I have verified it compiles but do not have the hardware.
> If you can please verify, thanks.

I no longer have access to Stallion hardware, so I can't test it.

Regards
Greg

------------------------------------------------------------------------
Greg Ungerer -- Chief Software Dude EMAIL: [email protected]
SnapGear -- a CyberGuard Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com

2004-03-21 13:14:20

by Christoph Hellwig

[permalink] [raw]

Subject: Re: [PATCH 2.6 stallion.c] RFT added class support to stallion.c

On Fri, Mar 19, 2004 at 06:08:47PM -0800, Hanna Linder wrote:
>
> Here is a patch to add class support to the Stallion multiport
> serial driver.
>
> I have verified it compiles but do not have the hardware.
> If you can please verify, thanks.
>
> Please consider for Inclusion or Testing.

Shouldn't this be covered by the tty subsystem?

2004-03-22 19:01:16

by Greg KH

[permalink] [raw]

Subject: Re: [PATCH 2.6 stallion.c] RFT added class support to stallion.c

On Sun, Mar 21, 2004 at 01:14:10PM +0000, Christoph Hellwig wrote:
> On Fri, Mar 19, 2004 at 06:08:47PM -0800, Hanna Linder wrote:
> >
> > Here is a patch to add class support to the Stallion multiport
> > serial driver.
> >
> > I have verified it compiles but do not have the hardware.
> > If you can please verify, thanks.
> >
> > Please consider for Inclusion or Testing.
>
> Shouldn't this be covered by the tty subsystem?

Seems that this driver also has a character device that it uses for some
non-tty like things :(

So yes, the main tty interface is already covered by the tty subsystem,
but this patch is still needed for full coverage of this driver.

thanks,

greg k-h

2004-03-25 18:47:15

by Greg KH

[permalink] [raw]