2017-12-19 22:20:14

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the btrfs-kdave tree

Hi David,

After merging the btrfs-kdave tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/btrfs/qgroup.c: In function 'qgroup_reserve':
fs/btrfs/qgroup.c:2432:1: warning: label 'retry' defined but not used [-Wunused-label]
retry:
^

Introduced by commit

b283738ab0ad ("Revert "btrfs: qgroups: Retry after commit on getting EDQUOT"")

--
Cheers,
Stephen Rothwell


2017-12-20 00:12:21

by Qu Wenruo

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the btrfs-kdave tree



On 2017年12月20日 06:20, Stephen Rothwell wrote:
> Hi David,
>
> After merging the btrfs-kdave tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/btrfs/qgroup.c: In function 'qgroup_reserve':
> fs/btrfs/qgroup.c:2432:1: warning: label 'retry' defined but not used [-Wunused-label]
> retry:
> ^
>
> Introduced by commit
>
> b283738ab0ad ("Revert "btrfs: qgroups: Retry after commit on getting EDQUOT"")
>
Sorry, I forgot to clean it up.

I'll update the patchset along with new patches to handle qgroup limit
better.

Thanks,
Qu

Attachments:
signature.asc (504.00 B)
OpenPGP digital signature

2017-12-21 16:51:43

by David Sterba

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the btrfs-kdave tree

On Wed, Dec 20, 2017 at 08:12:11AM +0800, Qu Wenruo wrote:
> On 2017年12月20日 06:20, Stephen Rothwell wrote:
> > After merging the btrfs-kdave tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > fs/btrfs/qgroup.c: In function 'qgroup_reserve':
> > fs/btrfs/qgroup.c:2432:1: warning: label 'retry' defined but not used [-Wunused-label]
> > retry:
> > ^
> >
> > Introduced by commit
> >
> > b283738ab0ad ("Revert "btrfs: qgroups: Retry after commit on getting EDQUOT"")
> >
> Sorry, I forgot to clean it up.
>
> I'll update the patchset along with new patches to handle qgroup limit
> better.

Meanwhile I've applied the fix from Arnd to silence the warning in
linux-next builds.

2017-12-22 00:32:16

by Qu Wenruo

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the btrfs-kdave tree



On 2017年12月22日 00:49, David Sterba wrote:
> On Wed, Dec 20, 2017 at 08:12:11AM +0800, Qu Wenruo wrote:
>> On 2017年12月20日 06:20, Stephen Rothwell wrote:
>>> After merging the btrfs-kdave tree, today's linux-next build (powerpc
>>> ppc64_defconfig) produced this warning:
>>>
>>> fs/btrfs/qgroup.c: In function 'qgroup_reserve':
>>> fs/btrfs/qgroup.c:2432:1: warning: label 'retry' defined but not used [-Wunused-label]
>>> retry:
>>> ^
>>>
>>> Introduced by commit
>>>
>>> b283738ab0ad ("Revert "btrfs: qgroups: Retry after commit on getting EDQUOT"")
>>>
>> Sorry, I forgot to clean it up.
>>
>> I'll update the patchset along with new patches to handle qgroup limit
>> better.
>
> Meanwhile I've applied the fix from Arnd to silence the warning in
> linux-next builds.
>

Some (not much, may be 2 or 3) patches is going to be updated:

btrfs: delayed-inode: Use new qgroup meta rsv for delayed inode and item
Revert "btrfs: qgroups: Retry after commit on getting EDQUOT" ( For the
lable)

And with 2 more new patches.

Do I need to resend the patchset or use separate patches for them?

Thanks,
Qu

Attachments:
signature.asc (504.00 B)
OpenPGP digital signature