2022-08-13 15:33:50

by min tang

Subject: [PATCH] treewide: Unneeded semicolon

There is no semicolon after '}' in line 78.

Signed-off-by: min tang <[email protected]>
---
tools/virtio/virtio-trace/trace-agent-ctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virtio/virtio-trace/trace-agent-ctl.c b/tools/virtio/virtio-trace/trace-agent-ctl.c
index 73d253d4b559..39860be6e2d8 100644
--- a/tools/virtio/virtio-trace/trace-agent-ctl.c
+++ b/tools/virtio/virtio-trace/trace-agent-ctl.c
@@ -75,7 +75,7 @@ static int wait_order(int ctl_fd)

if (ret)
break;
- };
+ }

return ret;

--
2.17.1

2022-08-13 16:54:56

by Conor Dooley

Subject: Re: [PATCH] treewide: Unneeded semicolon

On 13/08/2022 17:07, min tang wrote:
> [PATCH] treewide: Unneeded semicolon

Hey, you might want to check whatever script you're using to
generate these commits. A single line change in a file isn't
exactly treewide...

> There is no semicolon after '}' in line 1615.

This doesn't really make much sense, maybe:
"Remove uneeded semicolon after..."
Thanks,
Conor.

>
> Signed-off-by: min tang <[email protected]>
> ---
> fs/ntfs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
> index 5ae8de09b271..d663b49df84e 100644
> --- a/fs/ntfs/super.c
> +++ b/fs/ntfs/super.c
> @@ -1612,7 +1612,7 @@ static bool load_and_init_attrdef(ntfs_volume *vol)
> memcpy((u8*)vol->attrdef + (index++ << PAGE_SHIFT),
> page_address(page), size);
> ntfs_unmap_page(page);
> - };
> + }
> if (size == PAGE_SIZE) {
> size = i_size & ~PAGE_MASK;
> if (size)